Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide CBC dropdown if in error state #7516

Merged
merged 1 commit into from
Oct 27, 2023

Conversation

tillh-stripe
Copy link
Collaborator

@tillh-stripe tillh-stripe commented Oct 27, 2023

Summary

This pull request hides the CBC dropdown icon when we display the error state.

Motivation

Testing

  • Added tests
  • Modified tests
  • Manually verified

Screenshots

Before After
before screenshot after screenshot

Changelog

@tillh-stripe tillh-stripe marked this pull request as ready for review October 27, 2023 15:00
@tillh-stripe tillh-stripe requested review from a team as code owners October 27, 2023 15:00
@tillh-stripe tillh-stripe requested review from ccen-stripe and jaynewstrom-stripe and removed request for ccen-stripe October 27, 2023 15:00
@tillh-stripe tillh-stripe enabled auto-merge (squash) October 27, 2023 15:00
Copy link
Collaborator

@jaynewstrom-stripe jaynewstrom-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a reference to where you started doing the testing for this? Another option would be to pull this logic out of the UI to test it for now. Honestly we should probably do both.

@github-actions
Copy link
Contributor

Diffuse output:

OLD: paymentsheet-example-release-master.apk (signature: V1, V2)
NEW: paymentsheet-example-release-pr.apk (signature: V1, V2)

          │          compressed           │         uncompressed          
          ├───────────┬───────────┬───────┼───────────┬───────────┬───────
 APK      │ old       │ new       │ diff  │ old       │ new       │ diff  
──────────┼───────────┼───────────┼───────┼───────────┼───────────┼───────
      dex │   3.5 MiB │   3.5 MiB │ -30 B │   7.7 MiB │   7.7 MiB │ +16 B 
     arsc │   2.2 MiB │   2.2 MiB │   0 B │   2.2 MiB │   2.2 MiB │   0 B 
 manifest │   5.1 KiB │   5.1 KiB │   0 B │  25.4 KiB │  25.4 KiB │   0 B 
      res │ 900.8 KiB │ 900.8 KiB │   0 B │   1.3 MiB │   1.3 MiB │   0 B 
   native │   2.6 MiB │   2.6 MiB │   0 B │     6 MiB │     6 MiB │   0 B 
    asset │     3 MiB │     3 MiB │  +1 B │     3 MiB │     3 MiB │  +1 B 
    other │ 204.2 KiB │ 204.2 KiB │  -3 B │ 459.7 KiB │ 459.7 KiB │   0 B 
──────────┼───────────┼───────────┼───────┼───────────┼───────────┼───────
    total │  12.4 MiB │  12.4 MiB │ -32 B │  20.8 MiB │  20.8 MiB │ +17 B 

 DEX     │ old   │ new   │ diff      
─────────┼───────┼───────┼───────────
   files │     1 │     1 │ 0         
 strings │ 38423 │ 38423 │ 0 (+1 -1) 
   types │ 12625 │ 12625 │ 0 (+0 -0) 
 classes │ 10611 │ 10611 │ 0 (+0 -0) 
 methods │ 55314 │ 55314 │ 0 (+0 -0) 
  fields │ 35534 │ 35534 │ 0 (+0 -0) 

 ARSC    │ old  │ new  │ diff 
─────────┼──────┼──────┼──────
 configs │  292 │  292 │  0   
 entries │ 6930 │ 6930 │  0
APK
    compressed    │   uncompressed    │                               
──────────┬───────┼───────────┬───────┤                               
 size     │ diff  │ size      │ diff  │ path                          
──────────┼───────┼───────────┼───────┼───────────────────────────────
  3.5 MiB │ -30 B │   7.7 MiB │ +16 B │ ∆ classes.dex                 
  1.2 KiB │  -2 B │   1.2 KiB │   0 B │ ∆ META-INF/CERT.RSA           
  6.4 KiB │  +1 B │   6.2 KiB │  +1 B │ ∆ assets/dexopt/baseline.prof 
 65.4 KiB │  -1 B │ 146.8 KiB │   0 B │ ∆ META-INF/CERT.SF            
──────────┼───────┼───────────┼───────┼───────────────────────────────
  3.6 MiB │ -32 B │   7.9 MiB │ +17 B │ (total)
DEX
STRINGS:

   old   │ new   │ diff      
  ───────┼───────┼───────────
   38423 │ 38423 │ 0 (+1 -1) 
  + ~~R8{backend:dex,compilation-mode:release,has-checksums:false,min-api:21,pg-map-id:c63235d,r8-mode:full,version:8.1.65}
  
  - ~~R8{backend:dex,compilation-mode:release,has-checksums:false,min-api:21,pg-map-id:d0dd6b0,r8-mode:full,version:8.1.65}

@tillh-stripe tillh-stripe merged commit 1eca0e6 into master Oct 27, 2023
9 checks passed
@tillh-stripe tillh-stripe deleted the tillh/hide-cbc-dropdown-in-error-state-2 branch October 27, 2023 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants