[MOBILESDK-2482] Apply appearance API typography to dialog buttons (#…

…9850) * Apply appearance API typography to dialog buttons by assigning correct style. * Update screenshots * Update screenshots from bitrise * Add confirm close dialog tests with all appearances. * Update confirm close dialog tests with all appearances. * Update screenshots to align with bitrise
stripe · Jan 4, 2025 · a318b6a · a318b6a
1 parent eddadab
commit a318b6a
Show file tree

Hide file tree

Showing 15 changed files with 16 additions and 2 deletions.
diff --git a/payments-ui-core/src/main/java/com/stripe/android/ui/core/elements/SimpleDialogElementUI.kt b/payments-ui-core/src/main/java/com/stripe/android/ui/core/elements/SimpleDialogElementUI.kt
@@ -60,6 +60,7 @@ fun SimpleDialogElementUI(
                         } else {
                             Color.Unspecified
                         },
+                        style = MaterialTheme.typography.body1
                     )
                 }
             },
@@ -70,7 +71,10 @@ fun SimpleDialogElementUI(
                         onDismissListener()
                     }
                 ) {
-                    Text(dismissText)
+                    Text(
+                        text = dismissText,
+                        style = MaterialTheme.typography.body1
+                    )
                 }
             }
         )

diff --git a/paymentsheet/src/test/java/com/stripe/android/customersheet/CustomerSheetScreenshotTest.kt b/paymentsheet/src/test/java/com/stripe/android/customersheet/CustomerSheetScreenshotTest.kt
@@ -44,6 +44,16 @@ internal class CustomerSheetScreenshotTest {
             .fillMaxWidth(),
     )
 
+    @get:Rule
+    val paparazziWithEveryAppearance = PaparazziRule(
+        SystemAppearance.entries,
+        FontSize.entries,
+        PaymentSheetAppearance.entries,
+        boxModifier = Modifier
+            .padding(0.dp)
+            .fillMaxWidth(),
+    )
+
     @get:Rule
     val coroutineRule = CoroutineTestRule()
 
@@ -300,7 +310,7 @@ internal class CustomerSheetScreenshotTest {
 
     @Test
     fun testConfirmCloseDialog() {
-        paparazzi.snapshot {
+        paparazziWithEveryAppearance.snapshot {
             CustomerSheetScreen(
                 viewState = addPaymentMethodViewState.copy(
                     paymentMethodCode = PaymentMethod.Type.USBankAccount.code,

diff --git a/...creenshotTest_testConfirmCloseDialog[DarkTheme,DefaultFont,CrazyAppearance].png b/...creenshotTest_testConfirmCloseDialog[DarkTheme,DefaultFont,CrazyAppearance].png
diff --git a/...reenshotTest_testConfirmCloseDialog[DarkTheme,DefaultFont,CustomAppearance].png b/...reenshotTest_testConfirmCloseDialog[DarkTheme,DefaultFont,CustomAppearance].png
diff --git a/...eenshotTest_testConfirmCloseDialog[DarkTheme,DefaultFont,DefaultAppearance].png b/...eenshotTest_testConfirmCloseDialog[DarkTheme,DefaultFont,DefaultAppearance].png
diff --git a/...tScreenshotTest_testConfirmCloseDialog[DarkTheme,LargeFont,CrazyAppearance].png b/...tScreenshotTest_testConfirmCloseDialog[DarkTheme,LargeFont,CrazyAppearance].png
diff --git a/...ScreenshotTest_testConfirmCloseDialog[DarkTheme,LargeFont,CustomAppearance].png b/...ScreenshotTest_testConfirmCloseDialog[DarkTheme,LargeFont,CustomAppearance].png
diff --git a/...creenshotTest_testConfirmCloseDialog[DarkTheme,LargeFont,DefaultAppearance].png b/...creenshotTest_testConfirmCloseDialog[DarkTheme,LargeFont,DefaultAppearance].png
diff --git a/...reenshotTest_testConfirmCloseDialog[LightTheme,DefaultFont,CrazyAppearance].png b/...reenshotTest_testConfirmCloseDialog[LightTheme,DefaultFont,CrazyAppearance].png
diff --git a/...eenshotTest_testConfirmCloseDialog[LightTheme,DefaultFont,CustomAppearance].png b/...eenshotTest_testConfirmCloseDialog[LightTheme,DefaultFont,CustomAppearance].png
diff --git a/...enshotTest_testConfirmCloseDialog[LightTheme,DefaultFont,DefaultAppearance].png b/...enshotTest_testConfirmCloseDialog[LightTheme,DefaultFont,DefaultAppearance].png
diff --git a/...ScreenshotTest_testConfirmCloseDialog[LightTheme,LargeFont,CrazyAppearance].png b/...ScreenshotTest_testConfirmCloseDialog[LightTheme,LargeFont,CrazyAppearance].png
diff --git a/...creenshotTest_testConfirmCloseDialog[LightTheme,LargeFont,CustomAppearance].png b/...creenshotTest_testConfirmCloseDialog[LightTheme,LargeFont,CustomAppearance].png
diff --git a/...reenshotTest_testConfirmCloseDialog[LightTheme,LargeFont,DefaultAppearance].png b/...reenshotTest_testConfirmCloseDialog[LightTheme,LargeFont,DefaultAppearance].png
diff --git a/...ntsheet.ui_EditPaymentMethodUiScreenshotTest_testRemovalConfirmationState[].png b/...ntsheet.ui_EditPaymentMethodUiScreenshotTest_testRemovalConfirmationState[].png