valueToStarlark support for enumKind #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kathleen-stripe
approved these changes
Sep 7, 2021
| func NewProtoMessage(msg proto.Message) starlark.Value { | ||
| v, _ := protomodule.NewMessage(msg) | ||
| return v | ||
| func NewProtoMessage(msg proto.Message) (starlark.Value, error) { |
There was a problem hiding this comment.
Since this is a backwards-incompatible change, are you going to release these changes as a new (major?) version for skycfg?
There was a problem hiding this comment.
Yes, as I understand the current state is Skycfg has a single release tagged 0.1.0 and there have been a number of other API changes. Also as we learned in #95 API changes are easier to deal with than implementation changing untested behavior
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
valueToStarlarkwas missing support for enumKind so this PR:NewMessagefails to assign a value, updating the type signature inskycfg.gomsg == AsProtoMessage(NewMessage(msg))which catches the issuevalueToStarlarkTests
Added tests which should cover issues like this in the future