Protobuf API V2: finish implementation and switchover skycfg to using new impl #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seena-stripe
force-pushed
the
seena/protobuf-api-v2
branch
4 times, most recently
from
03cc116
to
d86f339
Compare
seena-stripe
force-pushed
the
seena/protobuf-api-v2
branch
from
d86f339
to
5a39b81
Compare
kathleen-stripe
approved these changes
Aug 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is currently stacked on top of #90, please review by commit
Summary
This PR completes the implementation on the new go protobuf v2 api, and makes the cutover to using the new implementation (points skycfg.go at go/protomodule, deletes internal/go/skycfg).
Specifically this pr
protomodule.go's global functions (e.g.proto.clear) to operate on the new*protoMessageobject rather than the old message type.packagetoprotomoduleand finishes implementingmessage_typeso thatpkg = proto.package("skycfg.test_proto")will return an object representing the package, and thenpkg.MessageV3returns an object (protoMessageType) (that can construct a new*protoMessagewithMessageV3internal/go/skycfg, but movesinternal/go/skycfg/skycfg_test.goto the top level directoryskcyfg.goto use the newgo/protomoduleTest
This PR adds the original
internal/go/skycfg/proto_test.goandinternal/go/skycfg/skycfg_test.goto testing the new implementationI have also tested this internally on our existing usage of skycfg, snapshotting before and after the implementation switch and confirming there are no differences in output (at least in our usage)