Fix regression in attaching event handlers #368
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & motivation
Fix for #365
In some integrations, the
useEffect
that callselements.on
seemed run whileelementRef.current
was stillnull
, resulting in the event handler never being attached. This (hopefully) fixes the issue by explicitly attaching the event handler any time we setelementRef.current
.Testing & documentation
element.on
when the merchant passes in a callback #360.onChange
event when it is mounted. #365 in my own integration; I will reach out on that thread after to confirm whether the fix was successful.