Support React 17 #147
Merged
Support React 17 #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like the RTL upgrade uses some new TypeScript 3.8 syntax, which is causing the typechecking to fail. I'll fix this and reassign. |
| if (elementRef.current) { | ||
| elementRef.current.destroy(); | ||
| React.useEffect(() => { | ||
| const element = elementRef.current; |
There was a problem hiding this comment.
This change was recommended but not actually necessary. Made it in case it prevents any future bugs.
dweedon-stripe
approved these changes
Jan 15, 2021
This was referenced Jan 15, 2021
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR upgrades the
reactandreact-domdevelopment dependencies, and specifies that we now support React 17 in thepeerDependencies.React 17 changes the timing of when effects are cleaned up. This caused one of our tests to break, since it was synchronsly asserting that
element.destroywas called when an Element component was unmounted. To fix the test, I needed to upgrade our@testing-library/reactdependency to at least 10.4.7, which ensures that effects are flushed synchronously whenunmountis called in a test. I also upgraded a few related deps, just to keep us up to date.A different test failed due to the additional Concurrent Mode changes in React 17. As before, Concurrent Mode is proving to be too unstable to reliably support without breaking changes, so I've disabled this test.
All tests are now passing, and I did a quick smoke test in a sample React 16 and React 17 app.