This repository has been archived by the owner on Feb 27, 2023. It is now read-only.
Improve error message for missing store items #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidme-stripe
requested review from
csabol-stripe,
mshafrir-stripe and
yuki-stripe
| @@ -341,11 +341,17 @@ def generate_payment_response(payment_intent) | |||
| "👚" => 2500, | |||
| } | |||
|
|
|||
| def price_lookup(product) | |||
| price = EMOJI_STORE[product] | |||
| raise "Can't find price for %s (%s)" % [product, product.ord.to_s(16)] if price.nil? | |||
There was a problem hiding this comment.
should we have a default price for something instead of raising an exception?
There was a problem hiding this comment.
I’d like to know why it’s happening instead of silently ignoring it: The Emoji store items should line up between the server and the client, so breakage could indicate a problem with Unicode parsing or something.
mshafrir-stripe
approved these changes
Nov 25, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding some additional logging to help diagnose #74.