Update sample store app #9
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
mshafrir-stripe
commented
Nov 1, 2019
•
mshafrir-stripe
commented
- Update stripe-android to v12.3.0
- Update backend API to reflect backend changes
- Update store product list and pricing to match backend
- Simplify models and use data class/@parcelize
- Update stripe-android to v12.2.0 - Update backend API to reflect backend changes - Update store product list and pricing to match backend - Simplify models and use data class/@parcelize
mshafrir-stripe
force-pushed
the
update
branch
from
e1f6767 to
bcba972
Compare
yuki-stripe
approved these changes
Nov 8, 2019
| if (data.shippingInformation != null) { | ||
| params["shipping"] = data.shippingInformation!!.toParamMap() | ||
| data.shippingInformation?.let { | ||
| params["shipping"] = it.toParamMap() | ||
| } | ||
| params["return_url"] = "stripe://payment-auth-return" |
There was a problem hiding this comment.
oh looks like this logic needs to be fixed - it should be a string (e.g. "fedex")
There was a problem hiding this comment.
will do in follow-up PR
Raulluna21
approved these changes
Jan 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.