[ST] Remove storageMap from the suite
#10440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lukas Kral <[email protected]>
henryZrncik
approved these changes
Aug 12, 2024
systemtest/src/test/java/io/strimzi/systemtest/tracing/OpenTelemetryST.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Lukas Kral <[email protected]>
jankalinic
approved these changes
Aug 12, 2024
Frawless
approved these changes
Aug 12, 2024
|
/packit test --labels regression |
|
/azp run upgrade |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
The failure in TF is not related to this PR - it's about OAuth and connection to Keycloak on aarch64 - which should be investigated in different PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description
This PR removes
storageMapfrom the last occurrences we have in our STs. Previously it was used for various things -> even during the tests to get theTestStorageobject etc.However, once the
ResourceManager.getTestContext()was added and change to theTestStorage, this is not really needed.The only place it can be useful is when we are getting start time for the test in the
tearDownTestCasein theassertNoCoErrorsLogged, which is currently not used anyway. Just because of that it's not useful to keep the Map, is it can be done differently and take just the value from the extensionContext.Additionally, for the other tests, some of the operations (like deletion of Jobs) is done now "automatically" or it can be done a little bit differently.
Checklist