[ST] Move KRaft and NodePools tests from FeatureGatesST to correct classes
#10432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run regression |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Signed-off-by: Lukas Kral <[email protected]>
Signed-off-by: Lukas Kral <[email protected]>
Signed-off-by: Lukas Kral <[email protected]>
im-konge
force-pushed
the
move-kraft-fg
branch
from
23acce1
to
2587070
Compare
|
/azp run regression |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Signed-off-by: Lukas Kral <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description
This simple PR moves the two tests -
testKafkaManagementTransferToAndFromKafkaNodePoolandtestKRaftMode- to different classes, as they are not using any feature gates (KRaft and NodePool FGs are GA) and they make more sense to be in the particular classes that are focused on that.The
testKRaftModewas moved to KafkaST, as it covers the Kafka in KRaft mode.The
testKafkaManagementTransferToAndFromKafkaNodePoolwas moved to KafkaNodePoolST, as it tests the transfer from/to KafkaNodePools (where all the tests in KafkaNodePoolST are focused on NodePools).Because these two tests were the only tests in the
FeatureGatesST, I "disabled" the class because it is empty, until we have another test that will cover some FG, we can remove the@Disabledannotation (which is there just for clarity) - the setup method for CO is useful and we have one FG that is not yet covered by ST, which we can add there ASAP.Checklist