Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Another set of unit tests rebased to use KRaft and Node Pools #10429

Merged

Conversation

scholzj
Copy link
Member

@scholzj scholzj commented Aug 7, 2024

Type of change

  • Task

Description

Another set of tests rewritten to use KRaft:

  • CruiseControlReconcilerTest and EntityOperatorReconcilerTest are not dependent on ZooKeeper and were just updated to use KRaft
  • KafkaRebalanceAssemblyOperatorTest does not use ZooKeeper in any way. The test was updated to use KRaft and I also addressed various IDE warnings
  • CaReconcilerTest was also mostly not related to ZooKeeper (as many of the tests are purely about the CA secrets) and the class was just updated to use KRaft. The two unit tests related to ZooKeeper were copied to a new CaReconcilerZooBasedTest class.

Checklist

  • Write tests
  • Make sure all tests pass

@scholzj scholzj added this to the 0.43.0 milestone Aug 7, 2024
@scholzj scholzj requested a review from ppatierno August 7, 2024 16:24
Copy link
Member

@ppatierno ppatierno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@scholzj scholzj merged commit 82546b7 into strimzi:main Aug 8, 2024
13 checks passed
@scholzj scholzj deleted the another-set-of-unit-tests-rewritten-to-KRaft branch August 8, 2024 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants