Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed unused method in the KafkaTest #10386

Merged
merged 2 commits into from
Jul 25, 2024

Conversation

ppatierno
Copy link
Member

Trivial PR to remove the unused rt method (also weird named) from the KafkaTest class.

Verified

This commit was signed with the committer’s verified signature.
friederbluemle Frieder Bluemle
Signed-off-by: Paolo Patierno <ppatierno@live.com>
@ppatierno ppatierno added this to the 0.43.0 milestone Jul 25, 2024
@ppatierno ppatierno requested a review from a team July 25, 2024 10:21

Verified

This commit was signed with the committer’s verified signature.
friederbluemle Frieder Bluemle
Signed-off-by: Paolo Patierno <ppatierno@live.com>
Copy link
Member

@scholzj scholzj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is it not used anymore? What was it used for?

@ppatierno
Copy link
Member Author

Why is it not used anymore? What was it used for?

I see it used just in one test back in 2020 which is not in the KafkaTest class anymore as well.

@Test
    public void testArrayRoundTrip()    {
        rt("Kafka-with-array");
    }

Copy link
Member

@scholzj scholzj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, thanks.

@ppatierno ppatierno merged commit 8ef366c into strimzi:main Jul 25, 2024
13 checks passed
@ppatierno ppatierno deleted the kafka-test-removed-unused-method branch July 25, 2024 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants