Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed ZooKeeper service usage to delete /controller znode on migration rollback #10373

Merged
merged 2 commits into from
Jul 24, 2024
Merged

Fixed ZooKeeper service usage to delete /controller znode on migration rollback #10373

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6520435
Fixed ZooKeeper service usage to delete /controller znode on migration
ppatierno Jul 23, 2024
7f19e0f
Fixed scholzj comment
ppatierno Jul 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...ator/src/main/java/io/strimzi/operator/cluster/operator/assembly/ZooKeeperReconciler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -898,7 +898,7 @@ protected Future<Void> maybeDeleteControllerZnode() {
*/
protected Future<Void> deleteControllerZnode() {
// migration rollback process ongoing
String zkConnectionString = KafkaResources.zookeeperServiceName(reconciliation.name()) + ":" + ZookeeperCluster.CLIENT_TLS_PORT;
String zkConnectionString = DnsNameGenerator.serviceDnsNameWithoutClusterDomain(reconciliation.namespace(), KafkaResources.zookeeperServiceName(reconciliation.name())) + ":" + ZookeeperCluster.CLIENT_TLS_PORT;
return KRaftMigrationUtils.deleteZooKeeperControllerZnode(
reconciliation,
vertx,
Expand Down
Loading