Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the GitHub comment feature as it doesn't work with PRs from forks #10316

Merged

Conversation

scholzj
Copy link
Member

@scholzj scholzj commented Jul 8, 2024

Type of change

  • Task

Description

Unfortunately, the comments from Azure CI that I added in #10242 when some forbidden changes are done do not work for PRs from forks 🤦. So I think we can remove it again because it would be just a maintenance effort without much value as all the people who can open PRs directly from the main repo should know what not to change :-(.

@scholzj scholzj added this to the 0.43.0 milestone Jul 8, 2024
@scholzj scholzj requested a review from a team July 8, 2024 14:33
@scholzj scholzj merged commit 0225fc1 into strimzi:main Jul 9, 2024
13 checks passed
@scholzj scholzj deleted the remove-the-commenting-on-github-functionality branch July 9, 2024 08:25
mstruk pushed a commit to mstruk/strimzi-kafka-operator that referenced this pull request Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants