Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expend feature gates support to all Strimzi operators #10141

Merged
merged 4 commits into from
May 23, 2024

Conversation

scholzj
Copy link
Member

@scholzj scholzj commented May 21, 2024

Type of change

  • Enhancement / new feature
  • Documentation

Description

This PR implements the Strimzi Proposal 74 and extends the support for Feature Gates to the User and Topic Operators. It moves the feature gate classes to the operator-common module, uses them in the TO and UO configuration and implements the propagation of the Feature Gates configuration from the CO to them as well.

Checklist

  • Write tests
  • Make sure all tests pass
  • Update documentation
  • Try your changes from Pod inside your Kubernetes and OpenShift cluster, not just locally
  • Update CHANGELOG.md

@scholzj scholzj added this to the 0.42.0 milestone May 21, 2024
@scholzj
Copy link
Member Author

scholzj commented May 21, 2024

/azp run regression

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@scholzj
Copy link
Member Author

scholzj commented May 21, 2024

/azp run feature-gates-regression

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@scholzj scholzj force-pushed the expand-feature-gates-to-all-operators branch from 9615e5f to 5d714a9 Compare May 22, 2024 07:13
Copy link
Member

@ppatierno ppatierno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I left just one nit.

Signed-off-by: Jakub Scholz <[email protected]>
Copy link
Member

@see-quick see-quick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

@PaulRMellor PaulRMellor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just a couple of suggestions.

Signed-off-by: Jakub Scholz <[email protected]>
@scholzj scholzj merged commit bd8f6a5 into strimzi:main May 23, 2024
13 checks passed
@scholzj scholzj deleted the expand-feature-gates-to-all-operators branch May 23, 2024 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants