Used Swagger2Markup 2.0.0-SNAPSHOT to fix path doc examples #429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Paolo Patierno <[email protected]>
scholzj
reviewed
Jun 16, 2020
There was a problem hiding this comment.
I'm fine with the implementation.
The idea is probably a bit questionable since the SNAPSHOT version probably changes with every build and every commit into their (master?) branch. So there is potential issue that:
- The new versions will introduce new issues and bugs
- The builds might not be reproducible (the SNAPSHOT changing, not everyone having the same cached SNAPSHOT version etc.)
|
That's a fair point I haven't thought. I will close this, but anyway we could live with the bugged doc for long time :-( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #420.
It's using the Swagger2Markdown 2.0.0-SNAPSHOT for now, while waiting for the final release (which seems not having an ETA) but at least we can have API documentation fixed.