Fix lint warnings and ensure lint fails on warnings

Rakefile

@@ -1,7 +1,7 @@
 require 'puppetlabs_spec_helper/rake_tasks'
 require 'puppet-lint/tasks/puppet-lint'
 
-PuppetLint.configuration.fail_on_warnings
+PuppetLint.configuration.fail_on_warnings = true
 PuppetLint.configuration.send('relative')
 PuppetLint.configuration.send('disable_80chars')
 PuppetLint.configuration.send('disable_class_inherits_from_params_class')

examples/mysql_plugin.pp

@@ -2,18 +2,22 @@
   root_password => 'password'
 }
 
-mysql::plugin{ 'validate_password':
+$validate_password_soname = $::osfamily ? {
+  windows => 'validate_password.dll',
+  default => 'validate_password.so'
+}
+
+mysql::plugin { 'validate_password':
   ensure => present,
-  soname => $::osfamily ? {
-    windows => 'validate_password.dll',
-    default => 'validate_password.so'
-  }
+  soname => $validate_password_soname,
+}
+
+$auth_socket_soname = $::osfamily ? {
+  windows => 'auth_socket.dll',
+  default => 'auth_socket.so'
 }
 
-mysql::plugin{ 'auth_socket':
+mysql::plugin { 'auth_socket':
   ensure => present,
-  soname => $::osfamily ? {
-    windows => 'auth_socket.dll',
-    default => 'auth_socket.so'
-  }
+  soname => $auth_socket_soname,
 }