-
-
Notifications
You must be signed in to change notification settings - Fork 961
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename Xenko to Stride #649
Conversation
// However I am not sure it's easy/possible to do it (using API) without doing a full restore/download, which we don't want to do | ||
// with old version (it might be uninstalled already and we want to avoid re-downloading it again) | ||
pendingPackageUpgradesPerPackage.TryGetValue(referencedProject.Package, out var dependencyPackageUpgraders); | ||
foreach (var dependencyPackageUpgrader in dependencyPackageUpgraders) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry if I'm jumping the gun and this is still a work in progress.
I've created a new SpriteStudio sample project and it crashed because dependencyPackageUpgraders
is null, because the TryGetValue directly above it failed. Wrapping it in an if statement allowed it to go through and the project is created without any issues.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point, something I overlooked when doing recent changes (I guess I was only testing upgrades, and didn't try new projects again yet).
Fixed with latest commit, thanks!
I was able to compile and create/run a new project. I did have a few errors when compiling tests but maybe that's already the case before the renaming (I need to check that). |
Another issue found: The custom shader ( |
ef01a2e
to
c6ad186
Compare
@Basewq thanks for the extensive testing, it helps a lot! Also, Game Studio in new version doesn't add Navigation/Physics to GameSettings anymore (which might not be referenced, causing game to crash at startup). |
Yep, the xksl alias issue is fixed. One minor issue: the auto-generated cs shader file correctly changes from |
Yes, your new changes have fixed the I'm not actively trying to test this (honest!), but...
If you try re-importing eg. StrideCrate.fbx, it'll import a material called XenkoLogo. I believe a few other fbx files will also be similar with this issue. |
…ings automatically to asset
@Basewq good catch, thanks! |
Another coincidence, I swear... |
@Basewq Fixed! |
PR Details
Rename Xenko to Stride
Motivation and Context
Background:
https://forums.xenko.com/t/xenko-help-us-find-a-new-name-logo-for-the-engine-if-we-have-to-rename/1980
https://forums.xenko.com/t/vote-for-xenkos-new-name/2016
Types of changes
Checklist