Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Xenko to Stride #649

Merged
merged 13 commits into from
Apr 19, 2020
Merged

Rename Xenko to Stride #649

merged 13 commits into from
Apr 19, 2020

Conversation

xen2
Copy link
Member

@xen2 xen2 commented Apr 11, 2020

PR Details

Rename Xenko to Stride

Motivation and Context

Background:
https://forums.xenko.com/t/xenko-help-us-find-a-new-name-logo-for-the-engine-if-we-have-to-rename/1980
https://forums.xenko.com/t/vote-for-xenkos-new-name/2016

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My change requires a change to the documentation.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@xen2 xen2 changed the title Stride renaming Rename Xenko to Stride Apr 11, 2020
// However I am not sure it's easy/possible to do it (using API) without doing a full restore/download, which we don't want to do
// with old version (it might be uninstalled already and we want to avoid re-downloading it again)
pendingPackageUpgradesPerPackage.TryGetValue(referencedProject.Package, out var dependencyPackageUpgraders);
foreach (var dependencyPackageUpgrader in dependencyPackageUpgraders)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry if I'm jumping the gun and this is still a work in progress.
I've created a new SpriteStudio sample project and it crashed because dependencyPackageUpgraders is null, because the TryGetValue directly above it failed. Wrapping it in an if statement allowed it to go through and the project is created without any issues.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, something I overlooked when doing recent changes (I guess I was only testing upgrades, and didn't try new projects again yet).
Fixed with latest commit, thanks!

@Kryptos-FR
Copy link
Member

I was able to compile and create/run a new project. I did have a few errors when compiling tests but maybe that's already the case before the renaming (I need to check that).

@Basewq
Copy link
Contributor

Basewq commented Apr 14, 2020

Another issue found: The custom shader (.xksl file) isn't renamed when upgrading an existing project to the new version. I'm assuming .xkfx will probably have the same issue.
The autogenerated .xksl.cs also isn't renamed. The using statements are renamed in the .xksl.cs file, except for a line declared as an aliasing:
using Buffer = Xenko.Graphics.Buffer;

@xen2 xen2 force-pushed the stride branch 3 times, most recently from ef01a2e to c6ad186 Compare April 15, 2020 09:03
@xen2
Copy link
Member Author

xen2 commented Apr 15, 2020

@Basewq thanks for the extensive testing, it helps a lot!
I have just pushed a new version which should hopefully behave much better for xksl/xkfx files.

Also, Game Studio in new version doesn't add Navigation/Physics to GameSettings anymore (which might not be referenced, causing game to crash at startup).
This helps for some specific samples which wouldn't work once upgraded to Stride.

@Basewq
Copy link
Contributor

Basewq commented Apr 15, 2020

Yep, the xksl alias issue is fixed.

One minor issue: the auto-generated cs shader file correctly changes from .cs to .sdsl.cs (ie. official 3.1 -> 4.0), no problems here.
However, it doesn't rename any files that were already as .xksl.cs (ie. some fairly recent commit version -> 4.0)
Not sure if you want to tailor for the bleeding edge users (doesn't matter to me, just making sure you're aware of this).

@xen2
Copy link
Member Author

xen2 commented Apr 15, 2020

@Basewq I initially thought it was OK to ignore since it wasn't released officially.
However, thinking about it again, I think vvvv (@tebjan) uses a version containing it already so I can add support for it (esp. since it's quite easy).
Thanks for making me think about it again!

@Basewq
Copy link
Contributor

Basewq commented Apr 16, 2020

Yes, your new changes have fixed the xksl.cs -> sdsl.cs issue.

I'm not actively trying to test this (honest!), but...
I created a new FPS sample template in the Stride editor. There are a few Asset warnings, eg.

Verbose:The model [Models/StrideCrate] from import [C:/FirstPersonShooter2/Resources/Models/StrideCrate.fbx] has been successfully imported.
Warning:Model references material 'XenkoLogo', but it was not defined in the ModelAsset.

If you try re-importing eg. StrideCrate.fbx, it'll import a material called XenkoLogo. I believe a few other fbx files will also be similar with this issue.
Nothing's crashing, so probably more of an FYI.

@xen2
Copy link
Member Author

xen2 commented Apr 17, 2020

@Basewq good catch, thanks!

@Basewq
Copy link
Contributor

Basewq commented Apr 18, 2020

Another coincidence, I swear...
The Launcher can't open any existing projects.
RecentProjectViewModel.OpenWith does a "name" search, but StrideVersionName is purely numeric because it's Version.ToString(), but StrideVersionViewModel.Name has now prepended PackageSimpleName, so the search always fails.

@xen2
Copy link
Member Author

xen2 commented Apr 19, 2020

@Basewq Fixed!
Thanks for the "coincidence testing", very helpful :)

@xen2 xen2 merged commit 273dfdd into stride3d:master Apr 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants