fix: PhysicsComponent reattach logic crashing the editor

[Basewq]

PR Details

Ignore reattach call if the component hasn't been attached yet.
This situation occurs when the editor gizmo wants to show the physics shape.

Not sure if null checking in both places is overkill or not, this shouldn't be a frequent call so any performance hit should be minimal. Maybe change to Debug.Assert in ReAttach()?

I've tested this opening the editor and at run-time and did not encounter any issue, however I did not test whatever the original implementation was for.
Also I couldn't build/run the tests (for an unrelated issue), so someone do a quick run to check this didn't break an existing test.

Related Issue

Fixes #2464
Caused by #2422 and #2439

Types of changes

• Docs change / refactoring / dependency upgrade
• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist

• My change requires a change to the documentation.
• I have added tests to cover my changes.
• All new and existing tests passed.
• I have built and run the editor to try this change out.

[Eideren]

Ran the physics tests, the test covering the initial issue, topdown and the editor repro and did not notice any issue.

Maybe change to Debug.Assert in ReAttach()?

A throw makes sense, it is called fairly infrequently as you said - the added overhead should be fine.
Thanks !