Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Compile Warning in OpenXR #2357

Merged
merged 3 commits into from
Jun 27, 2024
Merged

fix: Compile Warning in OpenXR #2357

merged 3 commits into from
Jun 27, 2024

Conversation

Arc-huangjingtong
Copy link
Contributor

PR Details

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist

its a very simple PR , fix a little Compile Warnings in Rider IDE

@VaclavElias
Copy link
Contributor

Thank you @Arc-huangjingtong 🙂. Please, could you update your PR and keep the original code styling and formatting, so the reviewers can focus on your specific code updates/changes and to keep consistency with the rest of our code base.

@Arc-huangjingtong
Copy link
Contributor Author

thanks this is my first PR 😄

@Arc-huangjingtong
Copy link
Contributor Author

@dotnet-policy-service agree

@VaclavElias
Copy link
Contributor

We all remember our first PR 🤣

@Eideren Eideren merged commit 53f4c1c into stride3d:master Jun 27, 2024
2 checks passed
@Eideren Eideren changed the title Fix Compile Warnings fix: Compile Warning in OpenXR Jun 27, 2024
@Eideren
Copy link
Collaborator

Eideren commented Jun 27, 2024

Thanks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants