Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: .NET 6 reference missed #2330

Merged
merged 4 commits into from
Jun 18, 2024
Merged

Conversation

Doprez
Copy link
Contributor

@Doprez Doprez commented Jun 15, 2024

PR Details

Updated error message to not confuse new users.

Should probably make a central var or something to make this better since there are a few places where .NET X is hard coded.

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My change requires a change to the documentation.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have built and run the editor to try this change out.

@Doprez Doprez marked this pull request as ready for review June 15, 2024 16:38
@Eideren
Copy link
Collaborator

Eideren commented Jun 17, 2024

Would using the current runtime's dotnet version instead of a hard-written one work in those cases ?

@Doprez
Copy link
Contributor Author

Doprez commented Jun 17, 2024

Good call:
image

@Eideren Eideren merged commit a19caf6 into stride3d:master Jun 18, 2024
12 of 13 checks passed
@Eideren Eideren changed the title .NET 6 reference missed fix: .NET 6 reference missed Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants