Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fullscreen and game exit windowing crashes #2274

Merged
merged 5 commits into from
Jun 1, 2024

Conversation

Doprez
Copy link
Contributor

@Doprez Doprez commented May 25, 2024

PR Details

There were 2 different issues here. One was an issue with the OnToggle event causing the switch from fullscreen to windowed to be reset to true within the same call causing an exception.

The other issue was with the exit game call trying to recreate a disposed graphics device in the GameBase class.

Related Issue

#2008
#1493

Motivation and Context

Window changes shouldnt cause a crash.

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My change requires a change to the documentation.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have built and run the editor to try this change out.

@Eideren Eideren changed the title Fix windowing crashes fix: fullscreen and game exit windowing crashes Jun 1, 2024
@Eideren Eideren merged commit 0e08dfd into stride3d:master Jun 1, 2024
13 of 14 checks passed
@Eideren
Copy link
Collaborator

Eideren commented Jun 1, 2024

Thanks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants