Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Add Reload test to TestContentManager #2272

Merged
merged 1 commit into from
May 25, 2024

Conversation

wrshield
Copy link
Contributor

PR Details

Description

Added a new test case to cover the Reload method in ContentManager.cs.
The test was added to TestContentManager.cs and is named SimpleReloadData.
The new test verifies the following functions of the Reload method:

  • Reloading an unloaded asset
  • Reloading a loaded asset
  • Reloading a loaded asset with a new URL to replace the asset

Related Issue

Motivation and Context

The Reload method in ContentManager previously had 0 test coverage, now it has 100% test coverage.

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My change requires a change to the documentation.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have built and run the editor to try this change out.

@Eideren Eideren merged commit 449ca3e into stride3d:master May 25, 2024
2 checks passed
@Eideren
Copy link
Collaborator

Eideren commented May 25, 2024

Looks great, thanks !

@Eideren Eideren changed the title Add Reload test to TestContentManager test: Add Reload test to TestContentManager May 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants