fix: Adjust ToolLocator for all platforms #2250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Adjust ToolLocator for all platforms * Introduce ToOSPath * Apply code review suggestion * Add ToOSPath() for msdfgen executable
|
What do you mean merge and delete this branch ? Merge #2142 and just ignore this branch changes and delete it, merge both and delete this branch afterward ? If the latter, what are those changes for exactly ? |
|
@Eideren Sorry for being imprecise. This branch contains only changes introduced in #2142 PR which was merged into |
Eideren
changed the title
|
No biggie, got it, thanks for the pr ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This branch is obsolete. Please merge changes (this branch contains only #2142 PR ) and delete this branch.