Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Enable to build engine and modeling related projects on any OS #2237

Merged
merged 1 commit into from
May 22, 2024

Conversation

Jklawreszuk
Copy link
Collaborator

@Jklawreszuk Jklawreszuk commented Apr 27, 2024

PR Details

Description

This PR enables to build following projects :

  • Stride.Assets.Models, Stride.Importer.Common, Stride.Importer.3D - these were restricted to win, because Visual c++ only available for NET FW - this is no longer the case
  • Stride.Games, Stride.Input - for some reason Stride.Core.prop adds net8.0-windows as Runtime framework but there is no windows specific code for both projects (update: Stride.Games is being used for GameStudio with WinForms). I restricted to windows only just in case

Motivation and Context

Make less windows restricted experience

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist

  • My change requires a change to the documentation.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have built and run the editor to try this change out.

@Eideren
Copy link
Collaborator

Eideren commented Apr 27, 2024

Looks good but it sounds like we have a couple of dependencies still, D3d11 failed:

C:\BuildAgent\work\b0fd06bda8666a37\sources\editor\Stride.Editor\Engine\EmbeddedGameForm.cs(13,37): error CS0246: The type or namespace name 'GameForm' could not be found (are you missing a using directive or an assembly reference?)

@Jklawreszuk
Copy link
Collaborator Author

Welp, At least it somehow explains what's the point of StrideExplicitWindowsRuntime. I found EnableWindowsTargeting dedicated for linux/macos platforms so this should work.

@Jklawreszuk Jklawreszuk marked this pull request as draft April 29, 2024 19:58
@Jklawreszuk Jklawreszuk force-pushed the remove-reduntant-runtime branch 2 times, most recently from a553205 to b40069a Compare May 22, 2024 17:32
@Jklawreszuk Jklawreszuk marked this pull request as ready for review May 22, 2024 20:25
@Jklawreszuk
Copy link
Collaborator Author

Jklawreszuk commented May 22, 2024

@Eideren It's possible that it was broken due to my previous PR, because I'm able to run the editor and the game. Could you try to run again?

@Eideren Eideren merged commit f33bcde into stride3d:master May 22, 2024
13 checks passed
@Eideren
Copy link
Collaborator

Eideren commented May 22, 2024

Yep, TC didn't error out, thanks !

@Jklawreszuk Jklawreszuk deleted the remove-reduntant-runtime branch September 8, 2024 01:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants