Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overwrite dialog fix #2183

Merged
merged 2 commits into from
Mar 10, 2024
Merged

Overwrite dialog fix #2183

merged 2 commits into from
Mar 10, 2024

Conversation

timconner
Copy link
Contributor

PR Details

Changes asset file import overwrite dialog to show the correct file being replaced.

Description

There is a bug in the current dialog that prompts if it is okay to overwrite the source file instead of the destination file. This PR corrects that so that it shows the correct file that is about to be replaced.

Additionally, added Path.GetFullPath to use/show the proper directory separator in an OS agnostic way as seen in other places in the project.

Related Issue

No issue created, but can easily be reproduced by importing an external resource twice and choosing to use the default location.

Motivation and Context

The current dialog makes it seem as if Stride is going to modify a file outside of the project, which is not true. This should help eliminate that confusion.

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My change requires a change to the documentation.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have built and run the editor to try this change out.

@timconner
Copy link
Contributor Author

@dotnet-policy-service agree

@tebjan
Copy link
Member

tebjan commented Mar 10, 2024

Very nice, thanks!

@tebjan tebjan merged commit ec3a6e8 into stride3d:master Mar 10, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants