-
-
Notifications
You must be signed in to change notification settings - Fork 958
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dependencies #2046
Merged
Eideren
merged 11 commits into
stride3d:master
from
Kryptos-FR:feature/central-package-management_update
Jan 11, 2024
Merged
Update dependencies #2046
Eideren
merged 11 commits into
stride3d:master
from
Kryptos-FR:feature/central-package-management_update
Jan 11, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kryptos-FR
force-pushed
the
feature/central-package-management_update
branch
4 times, most recently
from
November 20, 2023 11:25
7178c76
to
5129e2c
Compare
Kryptos-FR
force-pushed
the
feature/central-package-management_update
branch
from
November 22, 2023 21:44
5129e2c
to
fda64ad
Compare
Kryptos-FR
force-pushed
the
feature/central-package-management_update
branch
from
December 3, 2023 18:18
fda64ad
to
0fb54b2
Compare
…Package.Tests It might cause issues when building Stride.VisualStudio.Package.
Kryptos-FR
force-pushed
the
feature/central-package-management_update
branch
from
December 3, 2023 18:20
0fb54b2
to
4313f93
Compare
Kryptos-FR
force-pushed
the
feature/central-package-management_update
branch
from
December 3, 2023 18:22
4313f93
to
e6f1a89
Compare
@dotnet-policy-service agree |
…reak # Conflicts: # Directory.Packages.props
This was referenced Dec 7, 2023
Eideren
reviewed
Dec 8, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Try to avoid style changes, file scoped namespace in this case, diff tools really struggles with those so it's kind of a pain to review.
Other than that, looks good and works great, thanks a bunch @Kryptos-FR !
Kryptos-FR
force-pushed
the
feature/central-package-management_update
branch
from
December 9, 2023 12:57
ec54673
to
a8a2049
Compare
Thanks ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Details
Since moving to .NET 8 is already a breaking change, we can use this opportunity to update quite a few dependencies
Description
Should follow #2045.
This will require more testing, before it can be merged.
Motivation and Context
Types of changes
Checklist