Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies #2046

Merged

Conversation

Kryptos-FR
Copy link
Member

@Kryptos-FR Kryptos-FR commented Nov 17, 2023

PR Details

Since moving to .NET 8 is already a breaking change, we can use this opportunity to update quite a few dependencies

Description

Should follow #2045.

This will require more testing, before it can be merged.

Motivation and Context

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My change requires a change to the documentation.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have built and run the editor to try this change out.

@Kryptos-FR Kryptos-FR force-pushed the feature/central-package-management_update branch 4 times, most recently from 7178c76 to 5129e2c Compare November 20, 2023 11:25
@Kryptos-FR Kryptos-FR marked this pull request as ready for review November 20, 2023 11:26
@Kryptos-FR Kryptos-FR force-pushed the feature/central-package-management_update branch from 5129e2c to fda64ad Compare November 22, 2023 21:44
@Kryptos-FR Kryptos-FR force-pushed the feature/central-package-management_update branch from fda64ad to 0fb54b2 Compare December 3, 2023 18:18
…Package.Tests

It might cause issues when building Stride.VisualStudio.Package.
@Kryptos-FR Kryptos-FR force-pushed the feature/central-package-management_update branch from 0fb54b2 to 4313f93 Compare December 3, 2023 18:20
@Kryptos-FR Kryptos-FR force-pushed the feature/central-package-management_update branch from 4313f93 to e6f1a89 Compare December 3, 2023 18:22
@Kryptos-FR
Copy link
Member Author

@dotnet-policy-service agree

Copy link
Collaborator

@Eideren Eideren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Try to avoid style changes, file scoped namespace in this case, diff tools really struggles with those so it's kind of a pain to review.
Other than that, looks good and works great, thanks a bunch @Kryptos-FR !

sources/tests/xunit.runner.stride/App.axaml.cs Outdated Show resolved Hide resolved
@Kryptos-FR
Copy link
Member Author

Try to avoid style change

image
That should make diff easier to read.

@Kryptos-FR Kryptos-FR force-pushed the feature/central-package-management_update branch from ec54673 to a8a2049 Compare December 9, 2023 12:57
@Eideren Eideren merged commit 0f6f4ee into stride3d:master Jan 11, 2024
13 of 14 checks passed
@Eideren
Copy link
Collaborator

Eideren commented Jan 11, 2024

Thanks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants