-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: upgrade setup-go to v4 #1408
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@SuperQ Could you review this? |
LGTM, but maybe the test is flakey? |
SuperQ
approved these changes
Jul 6, 2023
This was referenced Jul 6, 2023
Merged
So strange that the tests pass now. |
@SuperQ Note that I have merged a few PRs yesterday and I have rebased my branch. |
dolmen
force-pushed
the
actions-setupgov4
branch
from
August 9, 2023 10:36
16f80b8
to
ac011f3
Compare
dolmen
force-pushed
the
actions-setupgov4
branch
from
October 10, 2023 14:55
ac011f3
to
d618ad0
Compare
This was referenced Oct 10, 2023
I had to merge #1451 instead, because I lack the permissions to merge my own MRs. 😭 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Upgrade CI to use setup-go v4
Motivation
Use latest features such as module cache.