Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade go module version to the minimum go version supported by the Go team #1317

Closed
wants to merge 2 commits into from
Closed

Upgrade go module version to the minimum go version supported by the Go team #1317

wants to merge 2 commits into from

Conversation

kishaningithub
Copy link

@kishaningithub kishaningithub commented Dec 17, 2022 •
edited
Loading

Summary

Fixes #1313

Changes

  • Upgrading go module version to 1.18 which is the least supported version by the golang team

@kishaningithub
Copy link
Author

Depends on #1301

@dolmen
Copy link
Collaborator

dolmen commented Jul 11, 2023

No. I want to support old projects as long as it is not too painful.
At this point I don't see a good reason for not allowing users of go 1.16 to upgrade to the latest release of testify.
Of course we will revise this when we'll use generics in the API.

@dolmen dolmen added Breaking Change github_actions Pull requests that update GitHub Actions code go1.19+ Change applies when running with go1.19+ rejected/invalid Not a bug but a misunderstanding by the requester labels Jul 11, 2023
@dolmen dolmen changed the title Upgrade go module version to the minimum go version supported by the go lang team Upgrade go module version to the minimum go version supported by the Go team Jul 12, 2023
@dolmen dolmen closed this Jul 12, 2023
@kishaningithub kishaningithub deleted the update-go-module-version branch July 13, 2023 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Breaking Change github_actions Pull requests that update GitHub Actions code go1.19+ Change applies when running with go1.19+ rejected/invalid Not a bug but a misunderstanding by the requester
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Consider updating declared Go version in go.mod
2 participants
@kishaningithub @dolmen