Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixing panic in calls to assertion with nil m.mutex #1212

Merged
merged 4 commits into from
Jun 24, 2022
Merged

fixing panic in calls to assertion with nil m.mutex #1212

merged 4 commits into from
Jun 24, 2022

Commits on Jun 23, 2022

  1. fixing panic in calls to assertion with nil m.mutex 

    This reverts a change that was made in stretchr#1182
The PR makes m.mutex a pointer which now needs to be checked but it's not checked for nil everywhere.

This should also help with these issues:
- stretchr#1208
- stretchr#1210
    Edward Raigosa authored Jun 23, 2022
    Configuration menu
    Copy the full SHA
    aca7672 View commit details
    Browse the repository at this point in the history

  2. Revert throwing out the lock because other concurrent calls can alrea… 

    …dy have it locked
    Edward Raigosa authored Jun 23, 2022
    Configuration menu
    Copy the full SHA
    8584c5e View commit details
    Browse the repository at this point in the history

  3. fix go vet copy lock by using pointer

    Edward Raigosa authored Jun 23, 2022
    Configuration menu
    Copy the full SHA
    192cfd9 View commit details
    Browse the repository at this point in the history

  4. fix obj assignment for passing test

    Edward Raigosa authored Jun 23, 2022
    Configuration menu
    Copy the full SHA
    4233f44 View commit details
    Browse the repository at this point in the history