don't copy mutex

[daniel-meyer-dme]

Summary

prevent govet: copylocks when referencing suite.Suite by using a pointer to the mutex

Changes

• switch mu to a pointer

Motivation

fix govet complaints

Related issues

Closes #1199

[boyan-soubachov]

Fixed in latest PR, thank you :)

[drichelson]

@daniel-meyer-dme @boyan-soubachov It looks like this change did not make it into master. See my comment here: #1199 (comment)

May I request we re-open this PR and merge it?

[RajeshDasari]

I see that this change is still not in master, any reason for it ? @daniel-meyer-dme @boyan-soubachov

[SVilgelm]

it is already in master: https://github.com/daniel-meyer-dme/testify/blob/master/suite/suite.go#L25

[RajeshDasari]

@SVilgelm Thanks for the response. But we are importing from github.com/stretchr/testify in our local go files. any plans to port the changes ?

[RajeshDasari]

we are getting the below error with the above change .

suite.go:73: test panicked: runtime error: invalid memory address or nil pointer dereference
goroutine 19 [running]:
runtime/debug.Stack()
/usr/lib/golang/src/runtime/debug/stack.go:24 +0x65
github.com/stretchr/testify/suite.failOnPanic(0xc0001501a0)
/home/radasari/rpmbuild/BUILD/test/vendor/github.com/stretchr/testify/suite/suite.go:73 +0x3e
panic({0x83d600, 0xb9df60})
/usr/lib/golang/src/runtime/panic.go:838 +0x207
sync.(*RWMutex).Lock(0x0?)
/usr/lib/golang/src/sync/rwmutex.go:139 +0x1e
github.com/stretchr/testify/suite.(*Suite).SetT(0xc0000c09b0, 0xc0001501a0)
/home/radasari/rpmbuild/BUILD/test/vendor/github.com/stretchr/testify/suite/suite.go:39 +0x3f
github.com/stretchr/testify/suite.Run(0xc0001501a0, {0x941038, 0xc0000c09b0})
/home/radasari/rpmbuild/BUILD/test/vendor/github.com/stretchr/testify/suite/suite.go:96 +0x93
test/src/test/pkg/api.TestCheckUserPasswdSuite(0x0?)
/home/radasari/rpmbuild/BUILD/test/src/test/pkg/api/checkuserpasswd_test.go:163 +0x39
testing.tRunner(0xc0001501a0, 0x8d82d0)
/usr/lib/golang/src/testing/testing.go:1439 +0x102
created by testing.(*T).Run
/usr/lib/golang/src/testing/testing.go:1486 +0x35f
--- FAIL: TestJsonStrucTypeSuite (0.00s)