Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

custom decorators settings are not synced #3315

Closed
sapphi-red opened this issue May 27, 2024 · 2 comments · Fixed by #3319
Closed

custom decorators settings are not synced #3315

sapphi-red opened this issue May 27, 2024 · 2 comments · Fixed by #3319

Comments

@sapphi-red
Copy link

sapphi-red commented May 27, 2024

I switched to the prerelease version (4.0.0) to try out #2887. (BTW thanks for implementing it)

The settings added in that PR seems to be not synced.
image
These settings are not machine-specific so I think it should be syncable.

The workaround is to set settingsSync.ignoredSettings.

@Jason3S
Copy link
Collaborator

Jason3S commented May 28, 2024

@sapphi-red,

Thank you for the feedback. I'll take another look at those settings. Originally I was worried that they would conflict between Windows and non-Windows systems. But, as you point out, it is more useful to carry the settings between systems.

Copy link
Contributor

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants