Skip to content
This repository has been archived by the owner on Aug 14, 2024. It is now read-only.

Buldings below streets are rendered above them #54

Closed
RubenKelevra opened this issue Feb 23, 2018 · 8 comments
Closed

Buldings below streets are rendered above them #54

RubenKelevra opened this issue Feb 23, 2018 · 8 comments

Comments

@RubenKelevra
Copy link

I know this is really minor, but I just wanted to just set this on the task-list.

Buildings with a lower level than streets should not be rendered above streets and sub-zero layer buildings maybe should be rendered at a higher opaque level? :)

Example data:

https://www.openstreetmap.org/way/82652409

screenshot_20180223-201059

@ENT8R
Copy link
Collaborator

ENT8R commented Feb 23, 2018

@matkoniecz
Copy link
Member

https://www.openstreetmap.org/way/378955812#map=19/52.51560/13.41816 is not tagged with location=underground, it is a OSM data issue (if that object is really underground) or invalid issue (if that object is not underground)

@ENT8R
Copy link
Collaborator

ENT8R commented Feb 24, 2018

It is underground:
thumb-2048
Otherwise it would be on top of this crossing...

@ENT8R
Copy link
Collaborator

ENT8R commented Feb 24, 2018

So it is an OSM issue... Should I add location=underground?

@ENT8R ENT8R closed this as completed Feb 24, 2018
@matkoniecz
Copy link
Member

So it is an OSM issue... Should I add location=underground?

Yes, and yes. I already made "add location=underground" edit for building, if you want you may do the same for other objects there.

@RubenKelevra Note that SC map will update once (a) server serving tiles will process my edit (b) your app cache will flush current data and download new one. (a) part may happen far in future, immediately or not at all.

@RubenKelevra
Copy link
Author

Thank for the clearification & the fast fix of OSM data... but still, a thing with layer=-2 should be rendered below something without layer-tag - where we assume layer=0 like streets, right?

@ENT8R
Copy link
Collaborator

ENT8R commented Feb 24, 2018

This is already done by the tile server...

@ENT8R
Copy link
Collaborator

ENT8R commented Feb 24, 2018

Buildings are normally rendered above streets.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants