Bicycle parking type

[matkoniecz]

fixes #330

Note, that is not mergeable - only xxhdpi drawable are added and authors are not documented.

But given that it is possible that images will be changed again I prefer to do both once at end once images are stabilized.

I am not 100% happy about any image but after next round of image searching, playing with saturation, recropping and other bikeshedding I am sending this as I think that it should be good enough (I am obviously willing to make changes if something is bad).

[matkoniecz]

@westnordost I attempted to play with saturation, contrast etc to improve the stand image - is it good enough? I asking as I am most likely to be biased here.

[rugk]

You may add "Fixes ..." in the PR description.

[westnordost]

Looks good 👍

[matkoniecz]

I added scaled images (I really need to make a script for that, manually rescaling in Gimp and copy-pasting it to proper folders is a poor method) and documented sources. It is now ready for merging.

[westnordost]

There is a plugin for Android Studio. I think it's called Batch Drawable Importer

…

On 1 March 2018 07:13:14 CET, Mateusz Konieczny ***@***.***> wrote: I added scaled images (I really need to make a script for that, manually rescaling in Gimp and copy-pasting it to proper folders is a poor method) and documented sources. It is now ready for merging. -- You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub: #923 (comment)

-- Diese Nachricht wurde von meinem Android-Mobiltelefon mit K-9 Mail gesendet.

[matkoniecz]

I found this one - unfortunately it is not working for me and it is no longer maintained ( winterDroid/android-drawable-importer-intellij-plugin#153 )

[ghost]

I think we should list more bicycle parking types than that. For example, where I live, bollards are quite common. They look like this, and are very visually distinct:

Some other common ones listed on the wiki are racks, anchors, and trees.

Also, this type of bicycle parking is common in my area:

They are visually distinct from the others, yet consensus says that they should be tagged as stands. As a user who knows nothing about OpenStreetMap, I wouldn't know to classify them as stands.

Same goes for this kind of parking, which I imagine would be intepreted as wheelbenders, since they only secure the front part of the wheel:

How can we minimize confusion?

[rugk]

Just add these images as another element selection and tag as stands, anyway.

[matkoniecz]

Note #330 (comment)

Please only search for pictures / include the following tags: and leave out rack and bollard.

[matkoniecz]

Also, explanation of difference between stands and wheelbenders may be put into "can't" say menu - like proposed for addresses in #917 (I already planned it as a future enhancement).

[ghost]

@matkoniecz Sorry, I didn't see the discussion there at #330. Though I would still argue that rack and bollard should be included, though, since they're more common than shed and lockers, and bollards are easily identifiable.

[ENT8R]

I really need to make a script for that, manually rescaling in Gimp and copy-pasting it to proper folders is a poor method

I did this for all answers for the new building quest (#774) 😄 Such a script would be a really big help!

[westnordost]

So, the plugin I use is called "Android Drawable Importer"

[westnordost]

Nothing to complain. Will be merged for v5. :-)

[matkoniecz]

Nothing to complain. Will be merged for v5. :-)

I am curious - is there some reason why merging in future is better than merging now? Are we in a feature freeze for 4.0?

[matkoniecz]

And thanks for a review!

[westnordost]

Yes. Feature freeze starts with the first beta of any major release. Any update that I make on this version will only be bugfixes or very minor things. Only when that version is stabilized an no major or minor things pop up anymore, I will continue work on the next major version. This is why it took me so long to review the building type quest.

[ghost]

@westnordost Sorry if spam, but do you have any response to my comments above? I think I was shadowbanned when I posted them, so they were hidden at first.

[matkoniecz]

I think I was shadowbanned when I posted them, so they were hidden at first.

These replies were shown to me and as far as I know Github has no shadow bans.

[westnordost]

@xotgucuni did you read through the discussion at #330?
Basically, the definition of racks is really unclear (i.e. search for bicycle rack on image search) and may be an umbrella term for all kinds of bicycle parking types. I umderstand it to be like wheelbenders but with a better design that is more secure and doesn't bend the wheels? The problem here is that there is no "typical" rack then, so adding this will rather add to confusion rather than otherwise. Additionally, if my above assumption is correct, there is really not any information value added as opposed to simply tagging as stands. In short:

1. bad definition in wiki might have burnt this tag. At least it needs to be clarified.
2. A typical picture would need to be found
3. Probably no meaningful difference to stands

Bollards are not in there because basically this is one of the many different possible stand designs. In terms of security, it is the same as stands, and this is what matters. I.e wide_stands are also not included.

[ghost]

@matkoniecz Getting off-topic, but my account was flagged when I created it, and I had to contact support to resolve this. Before that, I had noticed that my comments were hidden if I was logged out.

@westnordost Thanks, makes sense. I did eventually read through #330, but I just wasn't clear why other types were being excluded.