Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Opening Hours: Expect Swedish opening hours to differ on Saturdays #919

Merged
merged 2 commits into from
Feb 26, 2018

Conversation

andreasn
Copy link
Contributor

While a lot of shops in a big city in Sweden are open all days of
the week, Monday to Friday tend to have the same opening hours,
but shorter opening hours on Saturdays and Sundays.
This means that when setting the opening hours in StreetComplete,
you always have to uncheck Saturday first.

This commit fixes it to be Monday-Friday by default.

While a lot of shops in a big city in Sweden are open all days of
the week, Monday to Friday tend to have the same opening hours,
but shorter opening hours on Saturdays and Sundays.
This means that when setting the opening hours in StreetComplete,
you always have to uncheck Saturday first.

This commit fixes it to be Monday-Friday by default.
@westnordost
Copy link
Member

You need to run the generatecountrymetadata.py script in the app directory

@rugk
Copy link
Contributor

rugk commented Feb 26, 2018

Oh, come on, does he really need to? (Not every contributor can do so.) Can't you just do that before each release?

@andreasn
Copy link
Contributor Author

You need to run the generatecountrymetadata.py script in the app directory

I ran into some issues running the script (possibly missing decencies?). What does the script do?

@matkoniecz
Copy link
Member

It generates files used by app (for some technical reason app is not using file that you edited, ones actually used are generated).

And to not require python from everybody this script is not run as part of standard build.

@westnordost westnordost merged commit e3aa5ab into streetcomplete:master Feb 26, 2018
@westnordost
Copy link
Member

ok did it myself

@andreasn
Copy link
Contributor Author

Thank you! And thank you for all the hard work on the app in general. I love it!

@westnordost
Copy link
Member

westnordost commented Feb 27, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants