-
-
Notifications
You must be signed in to change notification settings - Fork 359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement bench backrest quest #830
Conversation
I can try to create one. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do you think that picnic tables are often (enough) mistagged as benches to warrant a specific handling for that?
(After all, there is always the leave-a-note option)
Also, what about cases where both picnic table and bench are mapped? User may mistakenly retag benches to tables. BTW, is there any, even potential use for this data? |
Perhaps useful information for the physically impaired / old people? @rugk seemed to be enthusiastic about this quest. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(Is missing an icon. Suggestion: A walking cane.)
So as for the use case, it may not only be for visually impared people. I still remember that OsmAnd may display difficult icons or so. 😄 Also there is even a map for that: https://www.mapcontrib.xyz/t/4da70b-Bancs_et_tables_de_pique_nique#
AFAIK this is not a valid mapping is it? Otherwise one may just need to remove the picnic option?
No, please not. Not only can this potentially be confused with tactile paving quests and similar, but it does also not really indicate that this is about a bench. |
I added a bench icon to the repository 🎉 |
app/src/main/res/values/strings.xml
Outdated
@@ -463,4 +463,6 @@ Otherwise, you can download another keyboard in the app store. Popular keyboards | |||
<string name="quest_internet_access_no">No connection</string> | |||
<string name="quest_busStopShelter_tram_name_title">"Does the tram stop \"%s\" have a shelter?"</string> | |||
<string name="quest_busStopShelter_tram_title">"Does this tram stop have a shelter?"</string> | |||
<string name="quest_bench_backrest_title">Does this bench has a backrest?</string> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
*have
# Conflicts: # app/src/main/res/values/strings.xml
Okay I did this now. Congrats for your first quest, @Map3428 :-) |
Fix #484
A neat icon is still missing, I can't design it.