Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement bench backrest quest #830

Merged
merged 4 commits into from
Feb 6, 2018

Conversation

Map3428
Copy link
Contributor

@Map3428 Map3428 commented Feb 3, 2018

Fix #484

A neat icon is still missing, I can't design it.

@ENT8R
Copy link
Contributor

ENT8R commented Feb 3, 2018

A neat icon is still missing, I can't design it.

I can try to create one.

Copy link
Member

@westnordost westnordost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you think that picnic tables are often (enough) mistagged as benches to warrant a specific handling for that?
(After all, there is always the leave-a-note option)

@matkoniecz
Copy link
Member

Also, what about cases where both picnic table and bench are mapped? User may mistakenly retag benches to tables.

BTW, is there any, even potential use for this data?

@westnordost
Copy link
Member

Perhaps useful information for the physically impaired / old people? @rugk seemed to be enthusiastic about this quest.

Copy link
Member

@westnordost westnordost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Is missing an icon. Suggestion: A walking cane.)

@rugk
Copy link
Contributor

rugk commented Feb 4, 2018

So as for the use case, it may not only be for visually impared people. I still remember that OsmAnd may display difficult icons or so. 😄

Also there is even a map for that: https://www.mapcontrib.xyz/t/4da70b-Bancs_et_tables_de_pique_nique#

Also, what about cases where both picnic table and bench are mapped?

AFAIK this is not a valid mapping is it? Otherwise one may just need to remove the picnic option?

(Is missing an icon. Suggestion: A walking cane.)

No, please not. Not only can this potentially be confused with tactile paving quests and similar, but it does also not really indicate that this is about a bench.
It is way easier: Just use a bench as an icon for that. AFAIK there is not a other quest, which may be asked about benches, so the icon would not even be used twice, potentially. (and even if it would, that is not so bad, as it the icon is used in the toilets quests or so twice)

@westnordost
Copy link
Member

I added a bench icon to the repository 🎉

@@ -463,4 +463,6 @@ Otherwise, you can download another keyboard in the app store. Popular keyboards
<string name="quest_internet_access_no">No connection</string>
<string name="quest_busStopShelter_tram_name_title">"Does the tram stop \"%s\" have a shelter?"</string>
<string name="quest_busStopShelter_tram_title">"Does this tram stop have a shelter?"</string>
<string name="quest_bench_backrest_title">Does this bench has a backrest?</string>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

*have

@westnordost
Copy link
Member

Okay I did this now. Congrats for your first quest, @Map3428 :-)

@westnordost westnordost merged commit cd4bd1e into streetcomplete:master Feb 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants