Add new quest for parking fee #825
Conversation
|
I would ask only for parking with tagged access to avoid "this parking is private" notes. Access may be tagged by a separate quest. |
|
Also, it is not clear what should be answered for parking that have fee or are free depending on
|
Use Android Studio (right click on /app/src/assets/ -> New | Vector asset)? |
I already excluded parkings with
Is there a fee to park here for all persons, no matter how long they stay and what time it is?
results in this: |
When saving the single icon to SVG for export, you need to select all and ungroup everything. (Ctrl-A Ctrl+Shift+G iirc). The Android vector drawable importer does not understand svg groups. Regarding this quest in general, I think we should put some more thought into this remark by @matkoniecz :
Yes, it may be. But note, quests should be designed around questions to ask, not tags to fill in. It's nice, when one coincides with the other. In this case, I am not entirely sure about it. How would the question of that separate quest sound like, and would be the reasonable answer options? |
Question: Who can use this parking?
|
Great! It works! Thank you! |
|
@ENT8R Also du würdest sagen, ein Parkplatz mit Parkgebühr fällt im normalen Sprachgebrauch schon nohc unter "öffentlicher Parkplatz", bzw. das eine hat nichts mit dem anderen zu tun? |
|
I denke, dass die meisten unter einem öffentlichen Parkplatz auch einen Parkplatz mit Parkgebühr verstehen. Gerade Parkplätze mit Parkgebühr sind ja meist für alle gedacht... Parkplätze für Kunden oder Mitarbeiter haben ja so gut wie nie eine Gebühr. |
|
Okay |
| { | ||
| @Inject public AddParkingFee(OverpassMapDataDao overpassServer) { super(overpassServer); } | ||
|
|
||
| @Override protected String getTagFilters() { return "nodes, ways with amenity=parking and access!=private and !fee"; } |
There was a problem hiding this comment.
Perhaps use access!~private|no in case someone tags parking lots' access with "no"?
There was a problem hiding this comment.
Or better use access ~ yes|customers|public like @matkoniecz said in #825 (comment) ?
There was a problem hiding this comment.
Ah wait, that would mean that parking lots without any access tagged would not be shown. Hmm, yeah, I guess, that is okay, if there is another quest that asks whether it is public or what else that becomes before this one in priority.
There was a problem hiding this comment.
"if there is another quest" AFAIK we have ticket open for that.
There was a problem hiding this comment.
Yes, it's #100. Should I also implement this?
There was a problem hiding this comment.
Given that this issue is open it probably would be welcomed...
There was a problem hiding this comment.
You can, but you do not have to to get this PR merged.
|
Especially with hotels we often have customers with fee |
This PR adds a new quest for adding whether there is a fee at a non-private parking.
It fixes #101
I even created a new icon for this quest, but I don't know how to convert the SVG to an Android XML Drawable... I tried tools like http://a-student.github.io/SvgToVectorDrawableConverter.Web/ and http://inloop.github.io/svg2android/ but both didn't work properly... How do you do this?
The quest will be a simple Yes/No quest and looks like this: