Implement filtering and reordering quest priorities #672
Conversation
| assertEquals(testQuestType, list.get(0)); | ||
| assertEquals(testQuestType2, list.get(1)); | ||
| } | ||
| } |
There was a problem hiding this comment.
Should probably also test:
- a QuestType is in QuestTypeOrderList but not in to-be-sorted list
- change quest type order (multiple "conflicting" apply() calls) -> should overwrite previous
| @@ -10,7 +10,7 @@ | |||
| import com.mapzen.android.lost.api.LocationServices; | |||
| import com.mapzen.android.lost.api.LostApiClient; | |||
|
|
|||
| /** Request ONE location update */ | |||
| /** Request ONE location onBind */ | |||
| @@ -128,7 +128,7 @@ else if(noProperRoad == AddRoadNameForm.IS_LINK) | |||
| } | |||
| } | |||
|
|
|||
| // these params are passed from the form only to update the road name suggestions so that | |||
| // these params are passed from the form only to onBind the road name suggestions so that | |||
Maybe "Long-press and move a quest to reorder its priority for download and display on the map." will be more clear? |
|
Is it now OK to propose quests for experts that may be unfixable from SC (at least until #471 is implemented)? For example - showing fixme tags (this quest is very useful in my experience, it allowed me to fix many long-standing fixme tags)? |
|
Maybe I missed something but it hides wheelchair and baby changing quests without notifying current users. Maybe give some feedback to current users (and also new ones, say after reaching 500 stars) that one may go to settings to enable additional quests? |
That would fit to https://github.com/westnordost/StreetComplete/issues/471… |
You wanted to link #471 |
Hm, no |
I do not think this is necessary.
That would be part of a larger feature to trigger certain events on reaching certain statistics. This is blocked until after we have proper user statistics. |
I think that for certain things, like here star count is enough (I assume that case of app reinstall resetting star count is rare enough that it is OK to repeat actions triggered by star count). |
# Conflicts: # app/build.gradle # app/src/main/AndroidManifest.xml # app/src/main/java/de/westnordost/streetcomplete/about/AboutFragment.java # app/src/main/java/de/westnordost/streetcomplete/data/StreetCompleteOpenHelper.java # app/src/main/res/layout/dialog_leave_note.xml # app/src/main/res/values/strings.xml
Implements #35
For public review.