Implement cycleways #671

westnordost · 2017-10-31T22:59:08Z

Fixes #139

For public review.

…e the same

…/track

# Conflicts: # app/src/main/assets/quests.png # app/src/main/assets/streetcomplete_quests.yaml # app/src/main/java/de/westnordost/streetcomplete/MainActivity.java # app/src/main/java/de/westnordost/streetcomplete/quests/QuestModule.java # app/src/main/java/de/westnordost/streetcomplete/tangram/MapFragment.java # app/src/main/res/values/strings.xml

This reverts commit 2416abc.

# Conflicts: # app/src/main/res/values/strings.xml

matkoniecz · 2017-11-02T20:59:39Z

Very impressive interface!

Nothing fits "road oneway for vehicles, not oneway for bicycles, no separate lane" normally tagged cycleway=opposite.

Nothing fits for "road oneway for vehicles, not oneway for bicycles, separate bicycle contraflow lane" - cycle lane option is displaying both general purpose lane (that may not exist in one direction) and cyclist lane.

maybe skip also surface=gravel and similar roads? http://www.openstreetmap.org/way/25116628#map=19/50.07320/19.88894 and similar are extremely unlikely to have cycleway infrastructure.

On oneway roads some answers make no sense and some may imply oneway:bicycle=no.

Open quest, rotate phone - question marks on unanswered parts are disappering (may affect also other parts of interface).

Would it be a good idea to have option to quickly select "no, there is no cycling infrastructure of any kind here"? Currently it requires tapping one direction, selecting none, tapping second direction, selecting none, selecting OK.

Generally, I am not sure whatever it makes sense to spam cycleway:both=no everywhere - but maybe it is result of

living in a city that is unfriendly to cyclists (so there is low amount of cycleways for tagging)
living in areas with well mapped cycling infrastructure (so what exists is mapped)
preferring mapping cycleways as separate ways

matkoniecz · 2017-11-02T21:02:43Z

Maybe skip also roads with low max speed? I think that maxspeed=20/30 roads are unlikely to have separate cycleways.

westnordost · 2017-11-02T21:06:16Z

Nothing fits "road oneway for vehicles, not oneway for bicycles, no separate lane" normally tagged cycleway=opposite.

Hmm because this is not really what this quest asks for. It asks for cycleways, not whether a oneway-road is not oneway for bicycles.

westnordost · 2017-11-02T21:10:51Z

Nothing fits for "road oneway for vehicles, not oneway for bicycles, separate bicycle contraflow lane" - cycle lane option is displaying both general purpose lane (that may not exist in one direction) and cyclist lane.

In that case, you are supposed to select simply what you see. I.e. you stand at the entrance of a oneway road and you see a cycleway lane on the left side (contraflow), you simply select "lane" for the left side (seen from your point of view) and "nothing" for right side. The quest automatically detects that this is indeed a contraflow-lane and tags it appropriately (oneway:bicycle=no, cycleway:left=lane, cycleway:left:oneway=-1).
See AddCyclewayTest.java

westnordost · 2017-11-02T21:11:57Z

Open quest, rotate phone - question marks on unanswered parts are disappering (may affect also other parts of interface).

BUG

westnordost · 2017-11-02T21:14:27Z

Would it be a good idea to have option to quickly select "no, there is no cycling infrastructure of any kind here"? Currently it requires tapping one direction, selecting none, tapping second direction, selecting none, selecting OK.

Hmm, I think it is fast enough as it is. It is basically 4 clicks vs. 2 clicks in that case.
I initially had a click-area in the middle of that street, when clicked, it would set both the left and the right side to the selected cycleway. But it was not self-explanatory enough and also too small to well distinguish from the other click areas.

matkoniecz · 2017-11-02T21:16:11Z

you simply select "lane" for the left side (seen from your point of view) and "nothing" for right side

It was not obvious for me that 1) it is OK to leave empty part of answer 2) app will be smart enough to recognize it as contraflow.

westnordost · 2017-11-02T21:17:33Z

No, it is not OK to leave a part empty. "Nothing" is an option in the dialog. It says "No cycleway" or "none" or something in English.

app will be smart enough to recognize it as contraflow.

You have no faith in me ;.-(

matkoniecz · 2017-11-02T21:18:09Z

Nothing fits "road oneway for vehicles, not oneway for bicycles, no separate lane" normally tagged cycleway=opposite.

Hmm because this is not really what this quest asks for. It asks for cycleways, not whether a oneway-road is not oneway for bicycles.

So app should add cycleway:both=none? Note that correct answer for explicitly marked contraflow without its own lane is cycleway:right=none, cycleway:left=opposite (or cycleway=opposite).

matkoniecz · 2017-11-02T21:22:22Z

No, it is not OK to leave a part empty. "Nothing" is an option in the dialog. It says "No cycleway" or "none" or something in English.

So to tag "lane in one direction for everybody, contraflow lane in opposite direction" (cycleway=opposite_lane) one should select "cycle lane" option and "none" option?

This results in interface displaying road with bicycle lane in one direction and general-purpose lanes in both directions. App will add correct information but user is unaware about that.

There should be way to achieve situation where app displays only cycleway lane in one direction and only general-purpose lane in other direction.

westnordost · 2017-11-02T21:23:43Z

So app should add cycleway:both=none? Note that correct answer is cycleway:right=none, cycleway:left=opposite (or cycleway=opposite).

The app does not use the opposite-tagging, there is an alternative way to tag it, namely oneway:bicycle=no.
I created a forum discussion about that recently. Sadly, it's in the German forum. Perhaps you want to use Google Translate if you are interested: https://forum.openstreetmap.org/viewtopic.php?id=59810

Only OSM experts would know that when thinking in tags, "a oneway road without cycleways but where cyclists can go in both directions" would be some kind of "cycleway".

westnordost · 2017-11-02T21:25:03Z

So to tag "lane in one direction for everybody, contraflow lane in opposite direction" (cycleway=opposite_lane) one should select "cycle lane" option and "none" option?

You mean there are cycleway lanes on both sides? Then, select both lane for left and for right. Just select what you see, do not worry about contraflow.
Or what do you mean with general-purpose lane? Explicitly shared lane with cars aka sharrows? Then select that.

matkoniecz · 2017-11-02T21:29:32Z

So to tag "lane in one direction for everybody, contraflow lane in opposite direction" (cycleway=opposite_lane) one should select "cycle lane" option and "none" option?

You mean there are cycleway lanes on both sides? Then, select both lane for left and for right. Just select what you see, do not worry about contraflow.

No, there is only contraflow lane. Typical in Poland.

matkoniecz · 2017-11-02T21:31:17Z

Only OSM experts would know that when thinking in tags, "a oneway road without cycleways but where cyclists can go in both directions" would be some kind of "cycleway".

Also for roads with explicit markings? Like in this case (especially as this symbol already appears as one of possibilities)

This is a second typical way of introducing contraflow in Poland.

westnordost · 2017-11-02T21:38:34Z

first picture

right: cycleway lane
left: no cycleway

second picture

right: explicit shared lane
left: no cycleway

matkoniecz · 2017-11-02T21:43:56Z

first picture

right: cycleway lane
left: no cycleway

This results in interface displaying road with bicycle lane in one direction and general-purpose lanes in both directions. App will add correct information but user is unaware about that.

second picture

right: explicit shared lane
left: no cycleway

"explicit shared lane" is named "lane shared explicitly with other traffic" despite that only bicycles are allowed in that direction.

Potential solutions:

add option "only cycle lane" (synonymous during edit to "cycle lane" but displayed differently in app, to avoid confusing users by showing general-purpose lanes in both directions for cases like first picture).

Rename "lane shared explicitly with other traffic" to "bicycles explicitly allowed without separate lane" to cover also cases like second picture.

matkoniecz · 2017-11-02T21:45:54Z

The app does not use the opposite-tagging, there is an alternative way to tag it, namely oneway:bicycle=no.

I created a forum discussion about that recently. Sadly, it's in the German forum. Perhaps you want to use Google Translate if you are interested: https://forum.openstreetmap.org/viewtopic.php?id=59810

AFAIK oneway:bicycle=no should be tagged in addition to cycleway/cycleway:both/cycleway:left/cycleway:right tags (and maybe it should be tagged for some answers in this quest). Unfortunately google translate and my German are not good enough to usefully participate in this discussion.

westnordost · 2017-11-02T22:40:51Z

Ah now I get it. The picture always shows a normal road next to the selected cycleway. You are suggesting that this can lead to misunderstandings for oneway-roads where there is usually only one lane

I guess a solution would be to have different pictures for when it is a oneway road perhaps? On the other hand, if the road has many more than 2 lanes, the pictures also do not change.

westnordost · 2017-11-02T22:42:30Z

Or, remove the center marking from the picture, so it is undefined how many lanes there are on the road, it is just a dark-gray surface.

matkoniecz · 2017-11-02T22:43:21Z

I guess a solution would be to have different pictures for when it is a oneway road perhaps?

That may be a better solution than ideas from #671 (comment)

Probably the best way to check is it necessary is to ask whatever others also would be confused (for example "if the road has many more than 2 lanes, the pictures also do not change" is not confusing for me).

Or, remove the center marking from the picture, so it is undefined how many lanes there are on the road, it is just a dark-gray surface.

O! I think that it would work, at least for me.

matkoniecz · 2017-11-02T22:51:19Z

app/src/main/java/de/westnordost/streetcomplete/quests/bikeway/AddCycleway.java

+		return overpassServer.getAndHandleQuota(getOverpassQuery(bbox), handler);
+	}
+
+	/** @return overpass query string to get streets without cycleway info not near paths roads that don't have names */


overpass query string to get streets without cycleway info not near paths roads that don't have names

is quite confusing, especially "roads that don't have names" given that there is no filtering by name that I see.

westnordost · 2017-11-03T23:39:20Z

@matkoniecz would you look again and see if it is better now in your opinion?

# Conflicts: # app/build.gradle # app/src/main/java/de/westnordost/streetcomplete/tangram/MapFragment.java # app/src/main/res/values/strings.xml

# Conflicts: # app/src/main/res/values/strings.xml

matkoniecz · 2017-11-21T22:08:11Z

It is basically 4 clicks vs. 2 clicks in that case.

For me it was still irritating enough that I made a separate quest with higher priority that asks whatever there is any cycling infrastructure.

At least in my city in overwhelming majority of cases I answer cycleway=no.

westnordost added 11 commits September 18, 2017 21:51

Implement quest cycleway #139

de78d19

Merge branch 'master' into cycleways

b89dd02

explicitly tag cycleway:both (and not just cycleway) if both sides ar…

fae6981

…e the same

also tag oneway:bicycle=no in oneways where there is an opposite lane…

ec1891f

…/track

more work on cycleways (+fix after merge)

1e8e92d

add tests

4907f0b

set up for UI tests step 1

2416abc

Revert "set up for UI tests step 1"

8f24611

This reverts commit 2416abc.

implement suggestion to exclude streets tagged as "bicycles not allowed"

0811cd0

Merge branch 'master' into cycleways

74c725d

# Conflicts: # app/src/main/res/values/strings.xml

matkoniecz reviewed Nov 2, 2017

View reviewed changes

westnordost added 3 commits November 2, 2017 23:53

fix default pictures are kept after screen rotate

f6184fe

fix comment

e46d029

remove center road marking for cycleway pictures

94eed34

westnordost added 2 commits November 4, 2017 17:42

Merge branch 'master' into cycleways

3dd27e8

# Conflicts: # app/build.gradle # app/src/main/java/de/westnordost/streetcomplete/tangram/MapFragment.java # app/src/main/res/values/strings.xml

Merge branch 'master' into cycleways

6d4e00b

# Conflicts: # app/src/main/res/values/strings.xml

westnordost merged commit 9612337 into master Nov 4, 2017

matkoniecz mentioned this pull request Nov 4, 2017

consider skipping some ways for cycleway quest #675

Closed

westnordost deleted the cycleways branch November 4, 2017 18:15

rugk mentioned this pull request Nov 5, 2017

Quest: oneway:bicycle #533

Closed

matkoniecz mentioned this pull request Dec 14, 2017

support oneway:bicycle=no also for cases where only contraflow infrastructure is present #717

Closed

matkoniecz mentioned this pull request Feb 18, 2022

Is this road oneway for bicycles too? #3778

Closed

5 tasks

mnalis pushed a commit to mnalis/StreetComplete that referenced this pull request Oct 3, 2024

add default disabled message for valves quest, fixes streetcomplete#671

09b7105

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implement cycleways #671

Implement cycleways #671

westnordost commented Oct 31, 2017

matkoniecz commented Nov 2, 2017

matkoniecz commented Nov 2, 2017

westnordost commented Nov 2, 2017

westnordost commented Nov 2, 2017

westnordost commented Nov 2, 2017

westnordost commented Nov 2, 2017

matkoniecz commented Nov 2, 2017

westnordost commented Nov 2, 2017

matkoniecz commented Nov 2, 2017 •

edited

Loading

matkoniecz commented Nov 2, 2017

westnordost commented Nov 2, 2017 •

edited

Loading

westnordost commented Nov 2, 2017 •

edited

Loading

matkoniecz commented Nov 2, 2017

matkoniecz commented Nov 2, 2017 •

edited

Loading

westnordost commented Nov 2, 2017

matkoniecz commented Nov 2, 2017

matkoniecz commented Nov 2, 2017 •

edited

Loading

westnordost commented Nov 2, 2017 •

edited

Loading

westnordost commented Nov 2, 2017

matkoniecz commented Nov 2, 2017 •

edited

Loading

matkoniecz Nov 2, 2017

westnordost commented Nov 3, 2017

matkoniecz commented Nov 21, 2017

Implement cycleways #671

Implement cycleways #671

Conversation

westnordost commented Oct 31, 2017

matkoniecz commented Nov 2, 2017

matkoniecz commented Nov 2, 2017

westnordost commented Nov 2, 2017

westnordost commented Nov 2, 2017

westnordost commented Nov 2, 2017

westnordost commented Nov 2, 2017

matkoniecz commented Nov 2, 2017

westnordost commented Nov 2, 2017

matkoniecz commented Nov 2, 2017 • edited Loading

matkoniecz commented Nov 2, 2017

westnordost commented Nov 2, 2017 • edited Loading

westnordost commented Nov 2, 2017 • edited Loading

matkoniecz commented Nov 2, 2017

matkoniecz commented Nov 2, 2017 • edited Loading

westnordost commented Nov 2, 2017

matkoniecz commented Nov 2, 2017

matkoniecz commented Nov 2, 2017 • edited Loading

westnordost commented Nov 2, 2017 • edited Loading

westnordost commented Nov 2, 2017

matkoniecz commented Nov 2, 2017 • edited Loading

matkoniecz Nov 2, 2017

Choose a reason for hiding this comment

westnordost commented Nov 3, 2017

matkoniecz commented Nov 21, 2017

matkoniecz commented Nov 2, 2017 •

edited

Loading

westnordost commented Nov 2, 2017 •

edited

Loading

westnordost commented Nov 2, 2017 •

edited

Loading

matkoniecz commented Nov 2, 2017 •

edited

Loading

matkoniecz commented Nov 2, 2017 •

edited

Loading

westnordost commented Nov 2, 2017 •

edited

Loading

matkoniecz commented Nov 2, 2017 •

edited

Loading