-
-
Notifications
You must be signed in to change notification settings - Fork 359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cycleway overlay: Differentiate bicycle access on pedestrian roads #6020
Conversation
My findings for d3a6c2b Pavement mode:
Cycleway mode:
|
Cool, thanks for testing it! I don't understand your comment about "pavement mode". Could you add a screenshot or something?
Oh! Weird, I thought I tested that. Will fix before merge.
Yes, overlaying things will overlay, ¯_(ツ)_/¯. However, pedestrian areas shouldn't actually be highlighted at all in this overlay and thus also not appear in front of these things. I will have a look. |
Ah I see, well, makes sense, but I'll implement that separately. |
One more litte remark. Maybe it is supposed to be, but: That's it. Thank you for your work :) |
Oh, yes, that's another bug |
app/src/main/java/de/westnordost/streetcomplete/overlays/cycleway/StreetCyclewayOverlayForm.kt
Show resolved
Hide resolved
app/src/main/java/de/westnordost/streetcomplete/overlays/cycleway/StreetCyclewayOverlayForm.kt
Show resolved
Hide resolved
app/src/main/java/de/westnordost/streetcomplete/overlays/cycleway/StreetCyclewayOverlayForm.kt
Show resolved
Hide resolved
app/src/main/java/de/westnordost/streetcomplete/overlays/cycleway/StreetCyclewayOverlayForm.kt
Show resolved
Hide resolved
Thanks for the review, @FloEdelmann ! |
You're welcome 🙂 For reference, the suggestions were applied in 6dbea87. |
fixes #6016
Changes: