Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

do not set foot=no when selecting a designated cycle track #5992

Closed
wants to merge 1 commit into from
Closed

do not set foot=no when selecting a designated cycle track #5992

wants to merge 1 commit into from

Conversation

olecky
Copy link

@olecky olecky commented Oct 30, 2024

see: #5991

@westnordost
Copy link
Member

westnordost commented Oct 30, 2024 •
edited
Loading

Cool! However, don't we also want to remove foot if EXCLUSIVE is selected? Or at least, it should be removed if it is not foot=no. (Not sure which would be the better option, maybe should be discussed)
Otherwise, if the way had e.g. foot=designated before, nothing would be changed.

Also, you probably need to adapt some tests in SeparateCyclewayCreatorKtTest.kt

@westnordost westnordost mentioned this pull request Oct 30, 2024
Closed
@FloEdelmann FloEdelmann linked an issue Oct 31, 2024 that may be closed by this pull request
Cycleway overlay: cycle track with walking allowed #5991
Closed
@westnordost
Copy link
Member

Closing, as it needs more discussion in the linked ticket.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cycleway overlay: cycle track with walking allowed
2 participants
@olecky @westnordost