Patch ref:FR:SIRET, ref:FR:SIREN and ref:FR:NAF when changing place #5917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, changing a place using the overlay remove all lot of old tags (opening_hours, brand, and many more) but the french SIRET and SIRENE code are kept. https://en.wikipedia.org/wiki/SIRET_code https://en.wikipedia.org/wiki/SIREN_code This patch addresses the situation
|
Perhaps you could add the french specific entries in a new line. |
|
note this should be updated at https://github.com/mnalis/StreetComplete-taginfo-categorize/ - here it will be replaced and lost on the next update |
|
@waterced Do you plan to make PR there? And thanks for working on it! Just that it needs to be addressed in a bit different place. |
|
Hi @matkoniecz , thanks for the feedback, yes I'll make a new PR there! |
This was referenced Sep 22, 2024
|
The PR there : mnalis/StreetComplete-taginfo-categorize#27 |
|
thanks! I will close this one then |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, changing a place using the overlay removes most of old tags that no longer apply to the new place, such as opening_hours, brand, and many more. The same should apply to the french SIRET, SIRENE and NAF codes, as discussed here (in french).
https://en.wikipedia.org/wiki/SIRET_code
https://en.wikipedia.org/wiki/SIREN_code
https://wiki.openstreetmap.org/wiki/Key:ref:FR:NAF
This patch addresses the situation