Implements AddBoardName quest #5882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mnalis
added
the
help wanted
kmpoppe
reviewed
Sep 8, 2024
westnordost
reviewed
Sep 8, 2024
app/src/main/java/de/westnordost/streetcomplete/quests/board_name/AddBoardName.kt
Outdated
Show resolved
Hide resolved
|
Will create an icon after merge. |
westnordost
approved these changes
Sep 9, 2024
|
Hm, I think the icon is fine. I tried with something like this
(T for Title or Text), but it doesn't really look good. A mash-up of the info board + label would also be too busy. |
FloEdelmann
added a commit
that referenced
this pull request
Sep 10, 2024
instead of duplicating it to ic_quest_board_name, see #5882
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #5871
Tested that it builds in https://github.com/mnalis/StreetComplete/actions/runs/10757025499; and it seems to work.
(made from bus_stop_name quest)
Help wanted:
ic_quest_board_name.xmlis copy of regularic_quest_label.xml), as I'm no artist 😃