Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude fee=no for AddAcceptsCards #5772

Merged
merged 2 commits into from
Jul 30, 2024

Conversation

HolgerJeromin
Copy link
Contributor

@HolgerJeromin HolgerJeromin commented Jul 30, 2024

@matkoniecz
Copy link
Member

This is asked for amenity ~ restaurant|cafe|fast_food|ice_cream|food_court|pub|bar so would not be asked for https://www.openstreetmap.org/node/7670739053

would not be asked also for https://www.openstreetmap.org/node/757197561 and https://www.openstreetmap.org/way/1214599523

fee=no for https://www.openstreetmap.org/node/338438554 was added by non-sc editor in edit titled "Specify toilet fees" so seems clearly spurious

is there any amenity ~ restaurant|cafe|fast_food|ice_cream|food_court|pub|bar where not only fee=no would be applicable but also there would be no possibility of even voluntary payment?

@matkoniecz matkoniecz added the feedback required more info is needed, issue will be likely closed if it is not provided label Jul 30, 2024
@HolgerJeromin
Copy link
Contributor Author

HolgerJeromin commented Jul 30, 2024

This is asked for amenity ~ restaurant|cafe|fast_food|ice_cream|food_court|pub|bar so would not be asked for https://www.openstreetmap.org/node/7670739053

You overlooked:

or (shop and shop !~ no|vacant|mall)

This "laundry" was really asked a few hours ago...

The other objects were found via a dirty overpass turbo search.

@matkoniecz matkoniecz removed the feedback required more info is needed, issue will be likely closed if it is not provided label Jul 30, 2024
@matkoniecz
Copy link
Member

I also repaired some clearly broken fee=no - including some reported here. See say https://www.openstreetmap.org/changeset/154606600

@matkoniecz
Copy link
Member

Oh, and have you tested this code? In emulator or on device?

(I have not done it so far)

@HolgerJeromin
Copy link
Contributor Author

Oh, and have you tested this code? In emulator or on device?

Tested on device with
https://github.com/HolgerJeromin/StreetComplete/actions/runs/10169947929
The laundry is not asked anymore.
This garden centre shop is still asked:
https://www.openstreetmap.org/way/37757063

@matkoniecz matkoniecz merged commit eb90c0d into streetcomplete:master Jul 30, 2024
@HolgerJeromin HolgerJeromin deleted the patch-1 branch July 31, 2024 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants