Remove improveosm oneway suspects quest

app/src/main/java/de/westnordost/streetcomplete/StreetCompleteApplication.kt

@@ -44,7 +44,6 @@ import de.westnordost.streetcomplete.data.user.statistics.statisticsModule
 import de.westnordost.streetcomplete.data.user.userModule
 import de.westnordost.streetcomplete.data.visiblequests.questPresetsModule
 import de.westnordost.streetcomplete.overlays.overlaysModule
-import de.westnordost.streetcomplete.quests.oneway_suspects.data.trafficFlowSegmentsModule
 import de.westnordost.streetcomplete.quests.questsModule
 import de.westnordost.streetcomplete.screens.about.aboutScreenModule
 import de.westnordost.streetcomplete.screens.main.mainModule
@@ -128,7 +127,6 @@ class StreetCompleteApplication : Application() {
                 questsModule,
                 settingsModule,
                 statisticsModule,
-                trafficFlowSegmentsModule,
                 uploadModule,
                 userModule,
                 arModule,

app/src/main/java/de/westnordost/streetcomplete/data/DatabaseInitializer.kt

@@ -25,11 +25,10 @@ import de.westnordost.streetcomplete.data.user.statistics.EditTypeStatisticsTabl
 import de.westnordost.streetcomplete.data.visiblequests.QuestPresetsTable
 import de.westnordost.streetcomplete.data.visiblequests.QuestTypeOrderTable
 import de.westnordost.streetcomplete.data.visiblequests.VisibleQuestTypeTable
-import de.westnordost.streetcomplete.quests.oneway_suspects.data.WayTrafficFlowTable
 
 /** Creates the database and upgrades it */
 object DatabaseInitializer {
-    const val DB_VERSION = 17
+    const val DB_VERSION = 18
 
     fun onCreate(db: Database) {
         // OSM notes
@@ -96,9 +95,6 @@ object DatabaseInitializer {
         db.exec(UserLinksTable.CREATE)
         db.exec(ActiveDaysTable.CREATE)
 
-        // quest specific tables
-        db.exec(WayTrafficFlowTable.CREATE)
-
         // logs
         db.exec(LogsTable.CREATE)
         db.exec(LogsTable.INDEX_CREATE)
@@ -248,6 +244,9 @@ object DatabaseInitializer {
         if (oldVersion <= 16 && newVersion > 16) {
             db.renameQuest("AddProhibitedForMoped", "AddMopedAccess")
         }
+        if (oldVersion <= 17 && newVersion > 17) {
+            db.exec("DROP TABLE direction_of_flow;")
+        }
     }
 }
 

app/src/main/java/de/westnordost/streetcomplete/data/osm/osmquests/OsmQuestController.kt

@@ -18,7 +18,6 @@ import de.westnordost.streetcomplete.data.quest.QuestTypeRegistry
 import de.westnordost.streetcomplete.quests.address.AddHousenumber
 import de.westnordost.streetcomplete.quests.cycleway.AddCycleway
 import de.westnordost.streetcomplete.quests.existence.CheckExistence
-import de.westnordost.streetcomplete.quests.oneway_suspects.AddSuspectedOneway
 import de.westnordost.streetcomplete.quests.opening_hours.AddOpeningHours
 import de.westnordost.streetcomplete.quests.place_name.AddPlaceName
 import de.westnordost.streetcomplete.util.Listeners
@@ -422,7 +421,6 @@ class OsmQuestController internal constructor(
  *  all have to wait for that one thread. So, better enqueue the expensive work at the beginning. */
 private val OsmElementQuestType<*>.chonkerIndex: Int get() = when (this) {
     is AddOpeningHours -> 0 // OpeningHoursParser, extensive filter
-    is AddSuspectedOneway -> 0 // Download, IO
     is CheckExistence -> 1 // FeatureDictionary, extensive filter
     is AddHousenumber -> 1 // complex filter
     is AddCycleway -> 2 // complex filter

app/src/main/java/de/westnordost/streetcomplete/quests/QuestsModule.kt

@@ -106,9 +106,6 @@ import de.westnordost.streetcomplete.quests.moped.AddMopedAccess
 import de.westnordost.streetcomplete.quests.motorcycle_parking_capacity.AddMotorcycleParkingCapacity
 import de.westnordost.streetcomplete.quests.motorcycle_parking_cover.AddMotorcycleParkingCover
 import de.westnordost.streetcomplete.quests.oneway.AddOneway
-import de.westnordost.streetcomplete.quests.oneway_suspects.AddSuspectedOneway
-import de.westnordost.streetcomplete.quests.oneway_suspects.data.TrafficFlowSegmentsApi
-import de.westnordost.streetcomplete.quests.oneway_suspects.data.WayTrafficFlowDao
 import de.westnordost.streetcomplete.quests.opening_hours.AddOpeningHours
 import de.westnordost.streetcomplete.quests.opening_hours_signed.CheckOpeningHoursSigned
 import de.westnordost.streetcomplete.quests.orchard_produce.AddOrchardProduce
@@ -187,12 +184,9 @@ import org.koin.dsl.module
 
 val questsModule = module {
     factory { RoadNameSuggestionsSource(get()) }
-    factory { WayTrafficFlowDao(get()) }
 
     single {
         questTypeRegistry(
-            get(),
-            get(),
             get(),
             { location ->
                 val countryInfos = get<CountryInfos>()
@@ -207,8 +201,6 @@ val questsModule = module {
 }
 
 fun questTypeRegistry(
-    trafficFlowSegmentsApi: TrafficFlowSegmentsApi,
-    trafficFlowDao: WayTrafficFlowDao,
     arSupportChecker: ArSupportChecker,
     getCountryInfoByLocation: (LatLon) -> CountryInfo,
     getFeature: (Element) -> Feature?,
@@ -427,7 +419,6 @@ fun questTypeRegistry(
     95 to AddMaxPhysicalHeight(arSupportChecker), // same as above, best if it appears right after (if enabled)
     96 to AddRoadName(),
     97 to AddOneway(),
-    98 to AddSuspectedOneway(trafficFlowSegmentsApi, trafficFlowDao),
 
     99 to AddEntrance(),
     100 to AddEntranceReference(),