Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Hungarian sign to quest fire_hydrant_diameter #5617

Merged
merged 1 commit into from
May 5, 2024

Conversation

dnet
Copy link
Contributor

@dnet dnet commented May 5, 2024

Since the German sign for fire hydrants is very similar to the Hungarian one, I forked that one and modified the H to T (for Tűzcsap). I compiled a debug build from this version and tested it in the emulator, it seemed to work well, see screenshot below.

Screenshot of debug build running in Android Studio emulator

@westnordost
Copy link
Member

westnordost commented May 5, 2024

Ah, I see, cool! Code looks fine, however are the quest guidelines fulfilled for asking for fire hydrant signs in Hungary? Most notably

💤 No spam: It must be possible to determine whether the quest should reasonably be asked. A quest which is to be answered in 99% of the time with the same answer is not a good quest, don't bore the users. I.e. asking for any road if it is a one-way road, is silly, because the vast majority of all roads will not be one-ways.

Just recently, I noticed that the hydrant sign in Austria is the same as in Germany, so I added Austria to the list of countries in which to ask for what this sign says. Only to be notified by Austrian user(s) that while that sign may exist, practically no hydrants in Austria do have a sign. So I removed Austria again from that list. See #5470

@westnordost westnordost added the feedback required more info is needed, issue will be likely closed if it is not provided label May 5, 2024
@dnet
Copy link
Contributor Author

dnet commented May 5, 2024

are the quest guidelines fulfilled for asking for fire hydrant signs in Hungary?

In most cases, yes, fire hydrants (at least on publicly accessible locations) have this sign in Hungary.

@westnordost westnordost removed the feedback required more info is needed, issue will be likely closed if it is not provided label May 5, 2024
@westnordost westnordost merged commit f46c856 into streetcomplete:master May 5, 2024
@westnordost
Copy link
Member

Cool! Thanks for the addition!

(Looking at this addition and the necessary copy-pasta duplication involved, I yearn towards migrating this stuff to Jetpack Compose)

@dnet dnet deleted the hu_fire_hydrant_diameter branch May 6, 2024 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants