Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add 'gas' as an option for bbq fuel #5495

Merged
merged 2 commits into from
Feb 24, 2024
Merged

add 'gas' as an option for bbq fuel #5495

merged 2 commits into from
Feb 24, 2024

Conversation

k-yle
Copy link
Contributor

@k-yle k-yle commented Feb 22, 2024

#5211 added a new quest to tag the fuel of a barbeque. The current options are wood, electric, or charcoal.

From my experience in Australia and New Zealand, public barbeques can sometimes be powered by gas. This could be LPG, gas mains, or BYO propane tank.

This PR adds gas as a new option.

@matkoniecz
Copy link
Member

matkoniecz commented Feb 22, 2024

Hello and welcome!

Can you add it also on https://wiki.openstreetmap.org/wiki/Tag:amenity%3Dbbq then if it is one more valid value?

@k-yle
Copy link
Contributor Author

k-yle commented Feb 22, 2024

Sure, I've updated that wiki page

Copy link
Member

@westnordost westnordost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

quest_bbq_fuel_gas must be defined in app/src/main/res/values/strings.xml

@westnordost westnordost merged commit 20efc19 into streetcomplete:master Feb 24, 2024
@k-yle k-yle deleted the gas-bbq branch February 24, 2024 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants