Implementation ViewModel improvements #5488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This paves the way for the next part of my commits.
Previously, the code was not idiomatic to how Kotlin Flows work. This is corrected with this commit. To do so, a separate function is used to create a callback flow on the logs controller. This is then called per new filter, and provided to the UI in that fashion. In response to work done: streetcomplete#5482
Because the actual List pointer is the same, there is no difference between the value sent to emit and the value still in the StateFlow. To correct this, A new list is created by appending an immutable list with the new value, which is then saved internally and emitted. In response to work done: streetcomplete#5482
LogsFragment was lagging my Android Interop on my System. This is because `notifyDataSetChanged` is used, it is computationally intensive and should never be used. Implementation of a quick DiffUtil calculator solves this. In response to work done: streetcomplete#5482
|
Your suggestion regarding SharedFlow, to solve the array copying, is it (not) also possible here? |
|
I mean, it is not that important, as you've tested. It did not lag before and it still does not lag, plus it is a screen that is rarely even visited. Live update of the logs is something of a nice-to-have-feature anyway. Just curious. |
I think it was simply time constraints and I forgot. 5dcc124 does this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From #5482