Add hint label to note text

[Helium314]

fixes #5398

This changes the note text as discussed in #5398.
I chose to use < and > for the link, as I suspect that links are parsed by different consumers (osm.org, notesReview, and probably more that I don't think of) and ideally none of them should produce broken links.

Though I'm not sure how nice this is in all cases, e.g. with level:
Unable to answer "Are these opening hours still correct?" for on level 2: Mobile Service (Mobile Phone Shop) https://...

[westnordost]

Well, to be absolutely sure, I guess one could also use spaces. E.g. ( https://www.dot.at ). Looks fine, too. But, your decision. LGTM

[FloEdelmann]

Though I'm not sure how nice this is in all cases, e.g. with level:
Unable to answer "Are these opening hours still correct?" for on level 2: Mobile Service (Mobile Phone Shop) ...

Another option would be Unable to answer "$question $hint" for $element, e.g. Unable to answer "Are these opening hours still correct? on level 2: Mobile Service (Mobile Phone Shop)" for osm.org/…

[Helium314]

Thanks, I think that looks better and it avoids the parentheses.

[Helium314]

Oh, that brings me to the next issue: It doesn't work for In context of "$overlayTitle" overlay for $element, e.g. In context of "Street Parking Service Road" overlay for http...
Maybe

• In context of overlay "$overlayTitle $hintTitle" for $element
  In context of overlay "Street Parking Service Road" for http...
• In context of overlay "$overlayTitle ($hintTitle)" for $element
  In context of overlay "Street Parking (Service Road)" for http...
• In context of "$overlayTitle" overlay ($hintTitle) for $element
  In context of "Street Parking" overlay (Service Road) for http...

I'd go for the second one if there is no objection or better idea.

[FloEdelmann]

I guess there is no easy way to append the hint text after the element URL? That would be consistent and clean:

• Unable to answer "$question" for $element ($hintTitle)
  Unable to answer "Are these opening hours still correct?" for http… (on level 2: Mobile Service (Mobile Phone Shop))
• In context of "$overlayTitle" overlay for $element ($hintTitle)
  In context of "Street Parking" overlay for http… (Service Road)

[westnordost]

Maybe without the "for" but instead with a "-"?

[westnordost]

Wrong placement of "?

Should it really be

Unable to answer "Are these opening hours still correct? - on level 2: Mobile Service (Mobile Phone Shop)"

and not rather

Unable to answer "Are these opening hours still correct?" - on level 2: Mobile Service (Mobile Phone Shop)

?

[Helium314]

I don't really have a preference here, if you like like the second variant more I'll change it.

[westnordost]

Yeah, I like the second option more, or actually, the full string would be

Unable to answer "Are these opening hours still correct?" - on level 2: Mobile Service (Mobile Phone Shop) for https://osm.org/node/....

wouldn't it? Actually, my suggestion was to not use "for" at all, but use "-", i.e.

Unable to answer "Are these opening hours still correct?" - on level 2: Mobile Service (Mobile Phone Shop) - https://osm.org/node/....

(Because the "for" feels out of place there, "phone shop for element", eh?