Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ask if amenity=car_sharing is still there #5400

Merged
merged 1 commit into from
Dec 15, 2023

Conversation

catdogmat
Copy link
Contributor

It has been briefly mentioned in the original "is it still there" issue (#2074) but hasn't been implemented or discussed any further.

I've just opened a few notes for car sharing stations which are probably gone. Would be useful to add this imo.

Originally posted by @dreua in #2074 (comment)
This PR fixes #5399

@dreua
Copy link

dreua commented Dec 7, 2023

Ha, I had no idea it would be that simple!

Copy link
Member

@matkoniecz matkoniecz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not really familiar with such places but it seems reasonable?

@westnordost
Copy link
Member

But why check every 4 years? I think it should be moved to line 68.

@catdogmat
Copy link
Contributor Author

But why check every 4 years? I think it should be moved to line 68.

They come and go quite alot where I live, as not many people use them.

@westnordost
Copy link
Member

Well, fair enough. I was thinking that this is the same class of things as e.g. a taxi stand or a motorcycle parking, which is in the 6-year category. But, let's not count peas.

@westnordost westnordost merged commit b0b2e09 into streetcomplete:master Dec 15, 2023
@matkoniecz
Copy link
Member

matkoniecz commented Dec 15, 2023

(also, it is possible to look at how people answered "is it still there" quests, look how old objects were at time of quest and tweak quest configuration based on that, I did it with some cases)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ask if amenity=car_sharing is still there
4 participants